Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315233 - Inconsistent use of "line" and "lineNumber" in JSON
Summary: Inconsistent use of "line" and "lineNumber" in JSON
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 10:55 EDT by Michael Rennie CLA
Modified: 2010-07-30 00:29 EDT (History)
1 user (show)

See Also:


Attachments
fix (4.11 KB, patch)
2010-07-30 00:28 EDT, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-06-01 10:55:13 EDT
code from HEAD

I found that when referencing a line number in JSON we use either "line" or "linenumber" we should use one only - I vote "line"

Examples:

the break event - "lineNumber" usage:

143
\r\n
{
  "type":"event",
  "seq":17,
  "event":"break",
  "body":{
          "contextId":0,
          "debuggerStatement":false,
          "threadId":1,
          "step":"in",
          "lineNumber":2,
          "scriptId":1}
}

the setbreakpoint request - "line" usage:

107
\r\n
{
  "command":"setbreakpoint",
  "seq":51,
  "type":"request",
  "arguments":{
               "condition":null,
               "line":10,
               "scriptId":1
              }
}
Comment 1 Michael Rennie CLA 2010-07-30 00:28:19 EDT
Created attachment 175537 [details]
fix

Removes the use of the attribute 'lineNumber' in favour of 'line'
Comment 2 Michael Rennie CLA 2010-07-30 00:29:06 EDT
applied patch to HEAD