Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315229 - KeyBindingDispatcher should not consume keys
Summary: KeyBindingDispatcher should not consume keys
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.1 RC1   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 10:47 EDT by Paul Webster CLA
Modified: 2011-05-13 14:48 EDT (History)
1 user (show)

See Also:

Attachments
Keys v01 (1.99 KB, patch)
2010-06-01 10:47 EDT, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-06-01 10:47:33 EDT 
Created attachment 170639 [details]
Keys v01

If the command is not handled, then the KBD should not consume the key presses.

This makes sure we check for a handler before we execute.

PW
Comment 1 Paul Webster CLA 2010-06-01 10:57:36 EDT 
It's released, but in e4 we don't support a proxy handler that the Command can return.

We need to think about how this will work compared with the compat workbench's Command#isHandled().

PW
Comment 2 Paul Webster CLA 2011-05-13 14:48:46 EDT 
This is fixed already, by looking up a handler.

PW