Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315225 - Run the Script w/Chart button always enabled
Summary: Run the Script w/Chart button always enabled
Status: CLOSED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Systemtap (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6   Edit
Assignee: anithra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 10:25 EDT by Andrew Overholt CLA
Modified: 2010-06-07 14:28 EDT (History)
3 users (show)

See Also:
anithra: review?

Attachments
Removes extraneous button (1.34 KB, application/octet-stream)
2010-06-06 12:43 EDT, anithra CLA 		anithra: review?
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2010-06-01 10:25:43 EDT 
It seems that the "Run the Script w/Chart" button is always enabled yet when I press it it says "The chosen operation is not currently available".  It would be nice to detect when it is available and only enable the button then :)
Comment 1 Andrew Overholt CLA 2010-06-04 17:19:35 EDT 
Will this be a similar fix to bug #315224?
Comment 2 Severin Gehwolf CLA 2010-06-04 17:36:38 EDT 
No, I believe the icon can be removed. There is a second (identical) one which is disabled/enabled as appropriate and which actually works.
Comment 3 anithra CLA 2010-06-06 12:43:09 EDT 
Created attachment 171221 [details]
Removes extraneous button
Comment 4 anithra CLA 2010-06-06 12:44:30 EDT 
Thanks Severin , you were right, attached a patch for review
Comment 5 Roland Grunberg CLA 2010-06-07 10:34:54 EDT 
Confirmed the bug, and the patch seems to fix this. The button is now correctly disabled.
Comment 6 anithra CLA 2010-06-07 11:34:23 EDT 
Thanks Roland, committed the patch.
Comment 7 Andrew Overholt CLA 2010-06-07 14:28:51 EDT 
I can confirm that by default the button is disabled in all 3 SystemTap perspectives.