Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315197 - [Intro] closing all perspectives disables the welcome page menu entry
Summary: [Intro] closing all perspectives disables the welcome page menu entry
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 08:28 EDT by Martin Skorsky CLA
Modified: 2019-11-14 03:25 EST (History)
3 users (show)

See Also:


Attachments
patch (3.96 KB, patch)
2011-09-27 08:27 EDT, Daniel Danev CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Skorsky CLA 2010-06-01 08:28:52 EDT
When I close all perspectives, the menu entry 'Help --> Welcome' is disabled.
Of course, this is minor. But for novice users, which stumble in a twisted UI where they need help, it is important to start again with the Welcome page.


-- Configuration Details --
Product: Eclipse SDK 3.6.0.v201005201744 (org.eclipse.sdk.ide)
Installed Features:
 org.eclipse.platform 3.6.0.v20100512-9gF78GpqFt6trMPh89Rz-jmqnMYpK-UpioD
Comment 1 Chris Goldthorpe CLA 2010-06-01 13:12:00 EDT
Closing all perspectives does indeed put the user into a situation where about the only useful thing they can do is open a perspective. I'm wondering why we allow users to close all perspectives from a menu - you can't do much in Eclipse without a perspective open. The two items in the Window menu  "Close Perspective" and "Close All Perspectives" don't seem to be particularly useful for most users, maybe the close perspective flow needs to be reconsidered. 

Passing to Platform UI for comment, I believe they own the Help/Welcome menu item.
Comment 2 Remy Suen CLA 2010-06-01 13:12:53 EDT
Pretty sure this isn't an enhancement request. ;)
Comment 3 Daniel Danev CLA 2011-09-27 08:27:32 EDT
Created attachment 204069 [details]
patch
Comment 4 Remy Suen CLA 2011-09-27 08:28:57 EDT
(In reply to comment #3)
> Created attachment 204069 [details]
> patch

This does not appear to be a text file.
Comment 5 Daniel Danev CLA 2011-09-27 08:30:51 EDT
The plug-in responsible for that issue is org.eclipse.ui.workbench. The reported issue is unfortunately hard-coded and can not be extended in the way of an extension somehow. That's why i'm attaching the simple solution i have to the problem.
1. Change in org.eclipse.ui.internal.IntroAction.java, and more specifically removing the action in pageClosed event for the IPageListener (Line 44)
2. Change in org.eclipse.ui.internal.WorkbenchIntroManager.java and more specifically in createIntro(IWorkbenchWindow preferredWindow) method to create a new "default" page when there isn't any active in the Workbench Window.

Both classes are attached as a zip archive bug_315197_patch.zip.
Comment 6 Daniel Danev CLA 2011-09-27 09:49:24 EDT
(In reply to comment #4)
> (In reply to comment #3)
> > Created attachment 204069 [details] [details]
> > patch
> 
> This does not appear to be a text file.

What's the correct format to upload the patch - should i upload the whole plug-in sources, each of the affected classes or something else.
Comment 7 Remy Suen CLA 2011-09-27 09:51:03 EDT
(In reply to comment #6)
> What's the correct format to upload the patch

Normally you would upload a diff.
http://wiki.eclipse.org/Platform_UI/How_to_Contribute
Comment 8 Remy Suen CLA 2011-09-27 09:52:07 EDT
(In reply to comment #6)
> What's the correct format to upload the patch - should i upload the whole
> plug-in sources, each of the affected classes or something else.

Though now that you've stated that it's actually a zip file and not a _patch_, it's clearer what needs to be done with that attachment.
Comment 9 Lars Vogel CLA 2019-11-14 03:25:29 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.