Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315189 - [AllDiagrams] - Updater: code generated with 3.6RC uses fully qualified names for descriptors
Summary: [AllDiagrams] - Updater: code generated with 3.6RC uses fully qualified names...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling
Classification: Modeling
Component: Samples (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Elena Shaverdova CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 07:17 EDT by Michael Golubev CLA
Modified: 2012-12-11 15:12 EST (History)
0 users

See Also:


Attachments
fixes the subj (1.02 MB, patch)
2010-06-01 08:34 EDT, Elena Shaverdova CLA
borlander: iplog+
borlander: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Golubev CLA 2010-06-01 07:17:12 EDT
Actually, after regeneration with GMF for 3.6RC, all UmlDiagramUpdater's contains the fully qualified names for UMLNodeDescriptor/UMLLinkDescriptor, like in the following snippet: 

public static List<org.eclipse.uml2.diagram.activity.part.UMLNodeDescriptor> getActivity_2026SemanticChildren(View view) {

for the old code, the type parameters were processed by the Organize Imports operation, so the same snippet was : 

public static List<UMLNodeDescriptor> getActivity_2026SemanticChildren(View view) {

it creates a huge diff for regeneration, without adding any structural/meaningful differences.

=> 

Either force Organize imports operation to process type parameteres, or commit the big generation diff in single commit (once) which does not include amy other changes.
Comment 1 Elena Shaverdova CLA 2010-06-01 08:34:44 EDT
Created attachment 170626 [details]
fixes the subj
Comment 2 Michael Golubev CLA 2010-06-01 08:47:17 EDT
Comment on attachment 170626 [details]
fixes the subj

reviewed, big but primitive change, no risk
Comment 3 Michael Golubev CLA 2010-06-01 08:48:02 EDT
Patch committed for structure/behavior diagrams
Comment 4 Michael Golubev CLA 2010-06-01 08:49:10 EDT
Fixed now, regeneration of the diagrams does not produces diffs for diagram updater.