Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315184 - [api] provide hook in AbstractRepositorySettingsPage on finish and cancel
Summary: [api] provide hook in AbstractRepositorySettingsPage on finish and cancel
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: 3.6   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331196
  Show dependency tree
 
Reported: 2010-06-01 06:14 EDT by Ilya Ivanov CLA
Modified: 2011-05-30 18:49 EDT (History)
1 user (show)

See Also:


Attachments
fix (4.35 KB, patch)
2011-05-30 18:47 EDT, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (16.35 KB, application/octet-stream)
2011-05-30 18:47 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Ivanov CLA 2010-06-01 06:14:40 EDT
Build Identifier: 

It would be great to have ability to handle Finish and Cancel events from AbstractRepositorySettingsPage. Here some example of implementation I've found in eclipse archive:

http://dev.eclipse.org/mhonarc/newsLists/news.eclipse.platform.jface/msg00182.html

Reproducible: Always
Comment 1 Steffen Pingel CLA 2010-07-09 22:15:04 EDT
Agreed. The tasks framework should provide a hook when performFinished() is invoked on the wizard. I'll tentatively schedule this for 3.5.
Comment 2 Steffen Pingel CLA 2011-02-26 04:33:06 EST
We ran out of time for 3.5. Moving to the next release cycle.
Comment 3 Steffen Pingel CLA 2011-05-30 18:47:30 EDT
Created attachment 196935 [details]
fix
Comment 4 Steffen Pingel CLA 2011-05-30 18:47:32 EDT
Created attachment 196936 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2011-05-30 18:49:54 EDT
I have added a new method performFinish(TaskRepository) to ITaskRepositoryWizardPage. To detect cancellation your best bet would probably be a dispose listener on the parent control and some code to check whether performFinish() was invoked prior to disposal or not.