Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315147 - Inconsistent use of 'ref' and 'handle' in JSON
Summary: Inconsistent use of 'ref' and 'handle' in JSON
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-31 17:02 EDT by Michael Rennie CLA
Modified: 2010-08-17 01:50 EDT (History)
1 user (show)

See Also:

Attachments
fix (6.69 KB, patch)
2010-08-17 01:48 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-05-31 17:02:22 EDT 
code from HEAD

in our RDWP we use the attributes 'ref' and 'handle' during look ups and frame operations. They are referring to the same idiom, and as such we should standardize on one or the other, not both. 

I vote we use ref and toss handle.
Comment 1 Michael Rennie CLA 2010-08-17 01:48:12 EDT 
Created attachment 176756 [details]
fix

the patch tosses 'handle' in favour of 'ref'
Comment 2 Michael Rennie CLA 2010-08-17 01:50:35 EDT 
applied patch to HEAD, all tests pass.

also updated the wiki spec: 

http://wiki.eclipse.org/JSDT/Debug/Rhino_Debug_Wire_Protocol