Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315143 - Put GraphingAPI preference in SystemTap category
Summary: Put GraphingAPI preference in SystemTap category
Status: VERIFIED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Systemtap (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6   Edit
Assignee: anithra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-31 16:27 EDT by Andrew Overholt CLA
Modified: 2010-06-07 14:33 EDT (History)
3 users (show)

See Also:

Attachments
Patch (937 bytes, patch)
2010-05-31 16:41 EDT, Roland Grunberg CLA 		no flags Details | Diff
proposed patch (1.58 KB, patch)
2010-06-04 17:18 EDT, Andrew Overholt CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2010-05-31 16:27:15 EDT 
The "GraphingAPI" preference should not be a top-level element of the Preferences.  This should be in the SystemTap category.
Comment 1 Roland Grunberg CLA 2010-05-31 16:41:57 EDT 
Created attachment 170592 [details]
Patch

Proposed patch to move GraphingApi preference group under SystemTap preference group.
Comment 2 Andrew Overholt CLA 2010-06-04 17:18:14 EDT 
Created attachment 171181 [details]
proposed patch

How about this patch which moves all SystemTap preferences into the SystemTap category?
Comment 3 Andrew Overholt CLA 2010-06-04 17:18:47 EDT 
Roland, can you review my patch?  It's similar to yours but moves a few more preference pages into the main SystemTap category.  Thanks.
Comment 4 Roland Grunberg CLA 2010-06-04 17:46:26 EDT 
This works for me.
Comment 5 anithra CLA 2010-06-06 10:02:19 EDT 
Works for me too..
Comment 6 Andrew Overholt CLA 2010-06-07 09:56:22 EDT 
Committed.  I'll verify in the next build.
Comment 7 Andrew Overholt CLA 2010-06-07 14:33:32 EDT 
I can confirm that all SystemTap-related preferences are now under the SystemTap category.
Comment 8 Andrew Overholt CLA 2010-06-07 14:33:56 EDT 
Verified using our N201006071201 build.