Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315133 - [Compatibility] View references need to be updated when switching between perspectives
Summary: [Compatibility] View references need to be updated when switching between per...
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M5   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 321864
  Show dependency tree
 
Reported: 2010-05-31 15:34 EDT by Remy Suen CLA
Modified: 2011-01-26 07:55 EST (History)
0 users

See Also:

Attachments
WorkbenchPage patch v1 (8.15 KB, patch)
2010-11-23 10:11 EST, Remy Suen CLA 		no flags Details | Diff
WorkbenchPage patch v2 (9.81 KB, patch)
2010-11-23 10:30 EST, Remy Suen CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-05-31 15:34:46 EDT 
1. Ctrl+F7, see a list of views.
2. Window > Open Perspective > Pick something else.
3. Ctrl+F7, see views from the first perspective incorrectly appear in this list.
Comment 1 Remy Suen CLA 2010-06-07 17:50:38 EDT 
They're also not getting removed. See WorkbenchPage's firePartClosed(CompatibilityPart).
Comment 2 Eric Moffatt CLA 2010-06-08 13:26:24 EDT 
Remy, come see me about this one. The LazyStackRenderer actually keeps track of which elements become visible or get hidden on a perspective switch but there's currently no API (event?) through which we can give the information back to the PartService.
Comment 3 Remy Suen CLA 2010-07-17 21:56:38 EDT 
This bug is responsible for the annoying problem where 'Team > Show History' doesn't do anything because you have that view open in another perspective.
Comment 4 Remy Suen CLA 2010-07-19 17:27:28 EDT 
(In reply to comment #3)
> This bug is responsible for the annoying problem where 'Team > Show History'
> doesn't do anything because you have that view open in another perspective.

Opened bug 320320 to workaround the problem because fixing this properly for 1.0 now is too risky in my opinion.
Comment 5 Remy Suen CLA 2010-07-19 17:27:49 EDT 
(In reply to comment #4)
> Opened bug 320320 to workaround the problem because fixing this properly for
> 1.0 now is too risky in my opinion.

That should be bug 320327.
Comment 6 Remy Suen CLA 2010-07-22 11:03:48 EDT 
Also should rollback the changes for bug 320573 when this gets fixed.
Comment 7 Remy Suen CLA 2010-11-23 10:11:58 EST 
Created attachment 183671 [details]
WorkbenchPage patch v1

Altered the relevant internal code to always go through the view references that are available in the current perspective instead of the global list.
Comment 8 Remy Suen CLA 2010-11-23 10:30:26 EST 
Created attachment 183673 [details]
WorkbenchPage patch v2

Simplified the code for removing references to depend only on when the part is actually destroyed.
Comment 9 Remy Suen CLA 2010-11-23 10:31:38 EST 
Fixed in CVS HEAD.
Comment 10 Remy Suen CLA 2010-12-07 10:33:16 EST 
Verified with I20101207-0250 on Windows XP. We no longer get a ridiculously long list of views when using Ctrl+F7.
Comment 11 Remy Suen CLA 2010-12-07 10:33:35 EST 
Whoops.
Comment 12 Remy Suen CLA 2011-01-19 16:09:53 EST 
getViewReferences() returns views outside the perspective but not the ones in the shared area.
Comment 13 Remy Suen CLA 2011-01-19 16:12:00 EST 
Fixed in CVS HEAD.
Comment 14 Remy Suen CLA 2011-01-26 07:55:34 EST 
Verified with I20110125-2200 on Windows XP.

Ctrl+F7 correctly shows views in regular part stacks, views in the shared area, views outside the perspective (in help's stack), and views in the perspective's detached windows.