Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315116 - Convert ArrayContentProvider to SessionSingleton
Summary: Convert ArrayContentProvider to SessionSingleton
Status: RESOLVED INVALID
Alias: None
Product: RAP
Classification: RT
Component: JFace (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-31 12:56 EDT by Stefan Röck CLA
Modified: 2010-06-01 03:19 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Röck CLA 2010-05-31 12:56:10 EDT 
After reading 314959 a remembered a strange implementation of JFace's ArrayContentProvider which has a public static getInstance() method to return a singleton instance (although a public ctor is visible as well).
Although this class has no state, extending classes potentially *could* have. In this case, the behavior between RCP and RAP is different as in RCP the state is hold per user, in RAP it is shared among all sessions. IMHO it makes sense to convert this to a session singleton, too.
Comment 1 Rüdiger Herrmann CLA 2010-05-31 14:08:33 EDT 
Even though the class itself could be extended, I don't see how anyone could manipulate getInstance() to return something else than ArrayContentProvider.

Please re-open if you disagree.
Comment 2 Stefan Röck CLA 2010-06-01 03:19:19 EDT 
You're right - I agree ;-)