Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315113 - Patch needed to fix SWT copyrights for 3.6
Summary: Patch needed to fix SWT copyrights for 3.6
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 RC4   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-31 12:40 EDT by Carolyn MacLeod CLA
Modified: 2010-05-31 14:30 EDT (History)
2 users (show)

See Also:
Silenio_Quarti: review+
kim.moir: review+


Attachments
patch for fix copyrights for SWT for 3.6 (1.00 KB, patch)
2010-05-31 12:40 EDT, Carolyn MacLeod CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2010-05-31 12:40:51 EDT
Created attachment 170562 [details]
patch for fix copyrights for SWT for 3.6

The attached patch works around a problem where the entire org.eclipse.swt project was accidentally deleted from HEAD by a bug in an automated build tool in July 2009. At the time, all SWT files were restored, however the file dates were all updated (even for very old, untouched files), which makes the "Fix Copyrights" tool think that every file was changed in July 2009.

The patch looks for the commit comment that was used for the restore, and if that was the last commit for a file, then the file is ignored. This patch was actually used for the Eclipse/IBM Fix Copyrights for SWT for 3.6 RC4, so if possible it should be committed to releng for 3.6 RC4 for consistency. It should be very safe, because it is enclosed in "if (swt ...)" which will only be true for the org.eclipse.swt project.
Comment 1 Kim Moir CLA 2010-05-31 13:18:47 EDT
Since it's RC4, two component leads need to approve this fix. Silenio, could you please approve?
Comment 2 Kim Moir CLA 2010-05-31 14:17:10 EDT
released for RC4
Comment 3 Carolyn MacLeod CLA 2010-05-31 14:30:20 EDT
Thanks, Kim!