Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315065 - Change URL for SAP server adapter
Summary: Change URL for SAP server adapter
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Vista
: P3 major (vote)
Target Milestone: 3.2 RC4   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-31 07:59 EDT by Kaloyan Raev CLA
Modified: 2017-10-11 16:33 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan)
arvera: pmc_approved? (naci.dai)
deboer: pmc_approved+
neil.hauge: pmc_approved+
arvera: pmc_approved? (kaloyan)
arvera: review+

Attachments
patch (1021 bytes, patch)
2010-05-31 07:59 EDT, Kaloyan Raev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2010-05-31 07:59:48 EDT 
Created attachment 170515 [details]
patch

The last time I requested change of the URL was in bug 302255. It looks like the URL given that time is not going to work due to problems in the SAP infrastructure. Therefore, I'd like to request another change for Helios. 

I know it is quite late already, but I hope this non-technical change can be included in RC4. 

Patch is attached. This time the URL given is an active one and after applying the patch the SAP server adapter should be shown in the list of available adapters.
Comment 1 Angel Vera CLA 2010-05-31 16:56:24 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
Without fixing the URL the adopter will be unable to display/show their server adapter.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 
The workaround would be to publish the new URL with some instructions, but it is not the desirable approach. 

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
Manually test url with a browser, and I also modified my source and launched WTP to ensure that the server adapter was displayed.

* Give a brief technical overview. Who has reviewed this fix? 
Angel has reviewed the fix. 

* What is the risk associated with this fix? 
minimal to none, as the if the URL fails to resolve we will simply skip that URL. But we know the URL works :)
Comment 2 David Williams CLA 2010-05-31 20:59:54 EDT 
important, safe. So I approve. 

But ... a sourceforge URL? I'll assume that's that you really meant, but thought I'd comment since it surprised me. 

Thanks.
Comment 3 David Williams CLA 2010-06-01 01:15:30 EDT 
(In reply to comment #2)

> 
> But ... a sourceforge URL? I'll assume that's that you really meant, but
> thought I'd comment since it surprised me. 
> 

Well, what a coincidence ... I saw this post a few hours later. 
http://www.sdn.sap.com/irj/scn/weblogs?blog=/pub/wlg/19319
Comment 4 Kaloyan Raev CLA 2010-06-01 02:36:53 EDT 
Yes, SourceForge. As I mentioned in the bug description we have some issues with providing unrestricted access to software in the SAP IT infrastructure. Therefore, a decision has been taken to move the server adapter to the open source world.
Comment 5 Angel Vera CLA 2010-06-01 11:41:11 EDT 
Committed to HEAD
Comment 6 Angel Vera CLA 2010-06-01 17:19:50 EDT 
changes released to HEAD
Comment 7 Eclipse Genie CLA 2017-10-11 16:33:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/108961