Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315011 - Add support for Eclipse-SourceReferences header
Summary: Add support for Eclipse-SourceReferences header
Status: CLOSED MOVED
Alias: None
Product: Subversive
Classification: Technology
Component: Core (show other bugs)
Version: 0.7   Edit
Hardware: All All
: P3 enhancement with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Igor Burilo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 327378 363138
  Show dependency tree
 
Reported: 2010-05-30 13:56 EDT by Stephan Herrmann CLA
Modified: 2023-02-13 10:54 EST (History)
5 users (show)

See Also:
avandorp: review?


Attachments
Proposed patch, tested with 1.1.0.I20130527-1700 and 1.1.3.I20140206-1700 (14.11 KB, patch)
2014-03-21 08:18 EDT, Michael Schaufelberger CLA
i.vinnykov: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2010-05-30 13:56:32 EDT
From bug 243582 comment 77:

 "People using SVN repos in releng builds will first need for the SVN
  implementation of the IFetchFactory to start generating values for the source
  references.  And I guess they also need to implement IBundleImporterDelegate
  for the UI extension point

  We should raise a bug on the svn guys with some guidance,  I haven't followed
  the UI side close enough to do this myself.  Perhaps a wiki would be useful."

This seems to overlap with, e.g., bug 195729 comment 18 which mentions the two
new extension points for this feature.
Comment 1 Stephan Herrmann CLA 2010-05-30 14:14:46 EDT
Some documentation can be found at
  http://wiki.eclipse.org/PDE/UI/SourceReferences
  http://wiki.eclipse.org/PDE/FAQ#How_do_I_add_.27Eclipse-SourceReferences.27_Headers

An example for the build-time part can be found in pde-build's
  org.eclipse.pde.internal.build.fetch.CVSFetchTaskFactory

An example for the import function can be found in pde-core's
  org.eclipse.pde.internal.core.importing.CvsBundleImporterDelegate
Comment 2 Michael Schaufelberger CLA 2014-03-21 08:18:15 EDT
Created attachment 241096 [details]
Proposed patch, tested with 1.1.0.I20130527-1700 and 1.1.3.I20140206-1700

With the attached patch, HEAD revisions of the projects denoted in Eclipse-SourceReferences can be imported.

You could also create a separate plug-in or fragment to get this functionality (create and register your own TeamProjectSetCapability and TeamProviderType) in case someone would want to quickly fix it locally.

Note that I didn't bother to do complete the NLS stuff.
Comment 3 Alexander Gurov CLA 2014-04-09 09:38:47 EDT
(In reply to Michael (msa) from comment #2)
Thank you for your help. The patch is applied and NLS support is added too.

Although I'm feeling pretty stupid, since i don't even understand how to check if it works and what is there to improve, since I don't know of any plug-ins that are accessible through SVN and use Eclipse-SourceReferences. :(

I did read the documentation Stephan suggested, also some information regarding PDE build, but it does not seem enough. I understand that I should:
1) install SVN PDE Build plug-in (easy part) 
2) then make a map file, so that SVNFetchFactory would be called (although there is no problem with understanding of the map file format, I can't find information on where it should be created and how it should be named)
3) then specify in the plug-in's build.properties generateSourceReferences = true
4) start build process for the plug-in
5) install plug-in that was built
6) try importing plug-in as described here: http://wiki.eclipse.org/PDE/UI/SourceReferences
Also will it work if I use pop-up menu item "Plug-in Tools->Build site"?

So, if you can recommend me something like "using PDE Build in Eclipse IDE for dummies" I would really appreciate it and will make next steps on solving this issue, like, for example, adding required support to SVNFetchFactory. :)
Comment 4 Stephan Herrmann CLA 2014-04-13 16:55:24 EDT
Sorry guys, in 2010 I would have been happy to test this via the Object Teams project, but meanwhile we've moved to git...
Comment 5 Eclipse Webmaster CLA 2023-02-13 10:54:55 EST
This issue has been migrated to https://gitlab.eclipse.org/eclipse/subversive/subversive/-/issues/58.