Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314961 - NPE protection in DiagramIOUtil
Summary: NPE protection in DiagramIOUtil
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.3   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.3   Edit
Assignee: Lidija Grahek CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 17:57 EDT by Lidija Grahek CLA
Modified: 2010-07-19 21:57 EDT (History)
2 users (show)

See Also:

Attachments
Patch (1.05 KB, patch)
2010-05-28 17:57 EDT, Lidija Grahek CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lidija Grahek CLA 2010-05-28 17:57:32 EDT 
Created attachment 170435 [details]
Patch

DiagramIOUtil.unload(...) calls diagram.eResource().unload(). However, in my case resource is already unloaded, so this call results in an NPE. Attached patch just adds a simple NPE protection.
Comment 1 Alex Boyko CLA 2010-05-31 00:19:21 EDT 
looks good to me
Comment 2 Anthony Hunter CLA 2010-05-31 11:08:59 EDT 
look good as well.
Comment 3 Lidija Grahek CLA 2010-05-31 11:29:42 EDT 
Committed to head.
Comment 4 Eclipse Webmaster CLA 2010-07-16 23:38:13 EDT 
[target cleanup] 2.3 RC was the original target milestone for this
bug
Comment 5 Eclipse Webmaster CLA 2010-07-19 21:57:55 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug