Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314954 - RCP contribution to the Target Platform Components category
Summary: RCP contribution to the Target Platform Components category
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 307298 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-28 16:25 EDT by Jeff McAffer CLA
Modified: 2012-04-25 16:00 EDT (History)
6 users (show)

See Also:


Attachments
screenshot showing the problems (42.55 KB, image/png)
2010-06-01 15:55 EDT, Jeff McAffer CLA
no flags Details
Name change (919 bytes, patch)
2010-06-02 09:38 EDT, John Arthorne CLA
no flags Details | Diff
patch (894 bytes, patch)
2010-06-02 11:58 EDT, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2010-05-28 16:25:29 EDT
The current RC2 Helios repo contains the RCP Developer Resources feature.  As I recall, this was only the source for RCP and what we really want in there is the RCP SDK feature.  Can we change the feature that is contributed to the category?

Related, the EclipseRT community has settled on the terminology "Target Components" rather than SDK for these things. So we would like to change the human readable name in the current RCP SDK feature to be "Eclipse RCP Target Components".

I'm happy to help where possible but need pointers to the current feature locations etc.
Comment 1 Kim Moir CLA 2010-06-01 14:47:28 EDT
Hi Jeff

There are two rcp related categories contributed to Helios
rcp.source.feature - source bundles in the rcp feature
org.eclipse.rcp.sdk.id - product iu for rcp sdk

So neither of these are suitable?  I'm not sure what you are asking me to change in terms of the Helios contribution.

As for changing the human readable name of the RCP feature, I'll ask John to comment before I change anything since the rcp feature is used by both the RT and Eclipse projects.
Comment 2 Jeff McAffer CLA 2010-06-01 15:55:14 EDT
Created attachment 170688 [details]
screenshot showing the problems

The IU with the ID "org.eclipse.rcp.sdk.id" should be the only IU categorized in the EclipseRT Target Platform category.  The attached screenshot shows that that IU is not present in the category and some other IU is.  The text name for that IU will read as "Eclipse RCP SDK" currently.

The second part of this bug is to have that IU's text name changed to Eclipse RCP Target Components. Note that there may or may not be an actual Feature with this ID.  I'm not sure how the IU is created.  That's more up your alley.

My search of Eclipse RC2's provided profile shows that the sdk.id IU is NOT present at all in the Eclipse install. In fact, the words RCP and SDK do not appear together at all in the install.
Comment 3 John Arthorne CLA 2010-06-02 09:38:26 EDT
Created attachment 170799 [details]
Name change

I think this is the name change Jeff is looking for. I have no idea how products can be assigned to categories so I don't know the answer to the first part.
Comment 4 Kim Moir CLA 2010-06-02 11:58:14 EDT
Created attachment 170824 [details]
patch

Patch for our child repo categories content.jar so Eclipse RCP Target Components appears as a new category with rcp binary and source included.
Comment 5 Kim Moir CLA 2010-06-02 15:07:09 EDT
*** Bug 307298 has been marked as a duplicate of this bug. ***
Comment 6 Jeff McAffer CLA 2010-06-02 21:16:23 EDT
I'm not sure if this will been an issue but the attached approach deviates from the norm.  We are not after a category here.  Not sure if it matters or not but, for example, it is imaginable that the p2/pde ui is not capable of finding/displaying a subcategory.  Similarly, the element we are after here should be in the repos included in the various RCP related downloads so that users can download a zip that has RCP in it (e.g., hte Platform SDK) and use that as a target repo and add in the RCP Target Components IU.

Like I say, I've no idea if it is a problem, just that it is not the way it has been done in the past.
Comment 7 Jeff McAffer CLA 2010-09-15 13:56:14 EDT
This is still a problem in the contribution to Helios SR1.  Kim has been pinged and is looking at it.
Comment 8 Kim Moir CLA 2010-09-15 14:39:52 EDT
Jeff, 

When we were talking on IM, you said

We contribute an IU to the Helios Target Components category. Currently it is the "RCP plugin developer resources" IU. Instead, it should be the RCP SDK.

The "RCP plugin developer resources" IU is the source iu. The RCP SDK is the product.  I'm not sure how we can contribute a product to the Helios build and associate it with a category. 

Here is what the equinox contribution to Helios looks like now

<?xml version="1.0" encoding="ASCII"?>
<aggregator:Contribution xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:aggregator="http://www.eclipse.org/b3/2010/aggregator/1.0.0" label="Equinox">
  <repositories location="http://download.eclipse.org/eclipse/updates/3.6.x" description="Eclipse and Equinox 3.6 milestones">
    <features name="org.eclipse.equinox.sdk.feature.group" versionRange="3.6.1.r361_v20100903-7H7R07v8rtOZyYbv1I6aZgou5z07">
      <categories href="helios.b3aggr#//@customCategories[identifier='EclipseRT%20Target%20Platform%20Components']"/>
    </features>
    <features name="org.eclipse.equinox.p2.discovery.feature.feature.group" versionRange="1.0.0.v20100510-4--9oB5855K7P"/>
    <features name="org.eclipse.rcp.source.feature.group" versionRange="3.6.1.r361_v20100827-9OArFLdFjY-ThSQXmJvKz0_T">
      <categories href="helios.b3aggr#//@customCategories[identifier='EclipseRT%20Target%20Platform%20Components']"/>
    </features>
  </repositories>
  <repositories location="http://download.eclipse.org/eclipse/updates/3.6.x" description="Eclipse and Equinox 3.6 release">
    <products name="org.eclipse.rcp.sdk.id" versionRange="3.6.0.M20100909-0800"/>
  </repositories>
  <contacts href="helios.b3aggr#//@contacts[email='kmoir@ca.ibm.com']"/>
</aggregator:Contribution>

I don't know how to associate the product id with the category so it shows up in the Helios repo.  Does anyone have any suggestions?
Comment 9 Jeff McAffer CLA 2010-09-15 16:16:45 EDT
I'm not expert in how the Helios build works but I suspect that if you put the RCP SDK product ID/version in instead of the org.eclipse.rcp.source.feature.group we should be good.  That id is an IU so unless they do some sort of check, the build won' t know the difference.
Comment 10 Jeff McAffer CLA 2010-09-15 16:36:23 EDT
From David W...

off hand, I don't know of a problem, but suspect there is some "checking" in the underlying model (on purpose or by accident) .... I know to get "products" in there at all took some extra work. You can just try it if you like ... as long as someone is on hand to revert if it doesn't work
Comment 11 Kim Moir CLA 2010-09-15 16:57:16 EDT
Thomas, 

Is there a way to specify a product id with a category and have it included properly in the b3 aggregator files? It seems today we just do that with feature ids.
Comment 12 Jeff McAffer CLA 2010-09-16 11:54:47 EDT
putting the product in instead of the feature IU did not seem to work. Not sure why but apparently the build failed with that configuration.

Given the lateness of this for Helios SR1 and no information on how to work around this problem I suggest that we just leave things as they are rather than panic to find some other way and potentially making things worse.  

If someone can see a way to make this happen that would be great but we may just have to live with it for SR1. Perhaps we can get this addressed for SR2 and Indigo?
Comment 13 Thomas Hallgren CLA 2010-09-17 01:23:22 EDT
In what way did it fail. Can you provid a trace?
Comment 15 Jeff McAffer CLA 2010-09-18 12:18:10 EDT
of course, build.eclipse.org seems to have died... With any luck the machine will be back with the relevant data sometime soon
Comment 16 Kim Moir CLA 2012-03-23 15:08:40 EDT
I think this can be closed.  3.6 was a long time ago.