Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314936 - Categories Listing is not dependent on the Market category children
Summary: Categories Listing is not dependent on the Market category children
Status: CLOSED FIXED
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.2   Edit
Assignee: Carsten Reckord CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, plan
Depends on:
Blocks:
 
Reported: 2010-05-28 14:37 EDT by Nathan Gervais CLA
Modified: 2013-03-01 11:22 EST (History)
2 users (show)

See Also:
ian.skerrett: kepler+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Gervais CLA 2010-05-28 14:37:31 EDT 
Recently i changed the API to only show categories for the tools market. However MPC still lists the categories for Tools when using the RCP Applications Market.  

Ian brought up the point with me yesterday that this should be controlled on the server rather then the client.  

Would it be possible to make it so that the client only displays what the API is sending for the Markets category children.
Comment 1 Carsten Reckord CLA 2013-02-06 11:20:30 EST 
Currently the combobox aggregates all categories from all markets (cf. MarketplaceWizardCommand l. 127ff).

I can simply change it to only show the categories of the currently selected markets and update the combobox when the market selection changes. I'd also sort the categories list alphabetically while I'm at it.
Comment 2 Ian Skerrett CLA 2013-02-28 09:08:32 EST 
(In reply to comment #1)
> Currently the combobox aggregates all categories from all markets (cf.
> MarketplaceWizardCommand l. 127ff).
> 
> I can simply change it to only show the categories of the currently selected
> markets and update the combobox when the market selection changes. I'd also
> sort the categories list alphabetically while I'm at it.

+1
Comment 3 Carsten Reckord CLA 2013-03-01 11:22:32 EST 
I've pushed a fix here https://git.eclipse.org/r/#/c/10661/ and it's already merged into master. Thanks Benny and Steffen for the review.

Categories are now updated on every switch between markets and sorted alphabetically.