Community
Participate
Working Groups
1. Launch the WS wizard. (Either top down or bottom up). Move the Service slider to "Start" and the Client slider to "test" 4. Press "Next" until you get to the "Test Web Service" Page. 5. The test facility should be the Web Services Explorer. Press "Launch". The WSE will open in an external browser. 6. Press next until you reach the "Web Service Client Test" page. 7. Select a test client, and press finish. Notice that the test client selected does not get launched when finished is pressed. This is because org.eclipse.jst.ws.internal.consumption.ui.widgets.test.FinishTestFragment is not working correctly due to in incorrect data mapping in our wizards.
Created attachment 170409 [details] proposed patch
Keith, can you please review this patch? It looks like the changes made in the fix for 180304 renamed this setter FinishTestFragment.setGenerateProxy(boolean) to .FinishTestFragment.setCanGenerateProxy(boolean) without updating all the data mappings correctly. The old mappings were invalid since there is no longer a setGenerateProxy method on FinishTestFragment.
Patch looks good. Some mappings were correctly changed, but these ones were not.
1. Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. On the "web service client test" page of the web service wizard, normally pressing finish would cause the selected test client to be launched. (for example the jax-rpc JSPs). This does not happen if the user launched the web services explorer earlier on the "test web service" page of the wizard. This is a very poor user experience. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? There is no workaround. 3. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manual testing in WTP and an adopter product. 4. Give a brief technical overview. Who has reviewed this fix? The web service wizard framework combines several commands to create web services and clients. Data is passed between these commands by setting up data bindings between these commands. A change was made in one of our commands, but not all of the corresponding data bindings were correctly updated causing the FinishTestFragment command to function incorrectly. This patch corrects this. Keith has reviewed this fix. 5. What is the risk associated with this fix? Almost zero risk.
Submitting for PMC approval. In layman's terms, with the patch, the FinishTestFragment command would be properly 'initialized' with the correct input data.
Sounds "major" to me (missing function, from end users point of view?) Did you mean to refer back to bug 180304 as the source of this error/regression? That's a very old bug.
(In reply to comment #6) > Sounds "major" to me (missing function, from end users point of view?) > > Did you mean to refer back to bug 180304 as the source of this > error/regression? > That's a very old bug. Yes, you expect the test facility to come up, but it doesn't. Yes, that's the correct bug, that's where the "CanGenerateProxy" data binding was added.
Thanks PMC. I've released the fix.
Verified fixed
Closing
