Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314925 - [api] add NodeHelper#getAttributeValueRegion
Summary: [api] add NodeHelper#getAttributeValueRegion
Status: CLOSED WONTFIX
Alias: None
Product: JSDT
Classification: WebTools
Component: Web (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 13:55 EDT by Ian Tewksbury CLA
Modified: 2010-05-28 15:56 EDT (History)
0 users

See Also:

Attachments
Patch (1.85 KB, patch)
2010-05-28 13:57 EDT, Ian Tewksbury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2010-05-28 13:55:20 EDT 
Right now NodeHelper only has a #getAttributeValue which returns the string value of a given attribute name but it would also be useful to have a #getAttributeValueRegion which would return the ITextRegion with the value.

Patch to follow.
Comment 1 Ian Tewksbury CLA 2010-05-28 13:57:01 EDT 
Created attachment 170394 [details]
Patch

This patch moves most of the logic in #getAttributeValue to a new method #getAttributeValueRegion and then calls this new method from the existing #getAttributeValue to prevent any duplicate code.
Comment 2 Nitin Dahyabhai CLA 2010-05-28 15:37:40 EDT 
(In reply to comment #0)
> Right now NodeHelper only has a #getAttributeValue which returns the string
> value of a given attribute name but it would also be useful to have a
> #getAttributeValueRegion which would return the ITextRegion with the value.

For what purpose?
Comment 3 Nitin Dahyabhai CLA 2010-05-28 15:50:07 EDT 
Doesn't fit the other methods on the class.
Comment 4 Ian Tewksbury CLA 2010-05-28 15:56:25 EDT 
closing.