Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314913 - ViewImpl#getChildren() implementation provokes performance issues
Summary: ViewImpl#getChildren() implementation provokes performance issues
Status: CLOSED WONTFIX
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: Notation (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 12:41 EDT by Alex Boyko CLA
Modified: 2023-02-05 11:15 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2010-05-28 12:41:01 EDT
The list of children returned in EContentsEList from two list features
The #get(int) method is implemented via iterators which is a performance killer.

Those are two lists we are accessing. It would be a good idea to come up with a custom read-only EList implementation to access to joint lists.

The GMF-runtime currently copies the whole list to access list entries by index.
Comment 1 Alex Boyko CLA 2010-05-28 15:24:14 EDT
We should also consider returning a write accessible list in ViewImpl#getVisibleChildren() to avoid cloning this list in the editpart code.
Comment 2 Eclipse Webmaster CLA 2010-07-19 12:30:43 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug
Comment 3 Aurelien Pupier CLA 2012-09-20 08:28:48 EDT
ViewImpl is in GMF-Notation.
Comment 4 Pierre-Charles David CLA 2022-12-28 10:04:28 EST
Eclipse GMF Notation is moving away from this bugs.eclipse.org issue tracker to
https://github.com/eclipse/gmf-notation.

If this issue is relevant to you and still present in the latest release:

* Create a new issue at https://github.com/eclipse/gmf-notation/issues/.
  * Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  * In the GitHub description, start with a link to this bugzilla ticket
  * Optionally add new content to the description if it can helps towards resolution
* Update bugzilla ticket
  * Add to "See also" property (up right column) the link to the newly created GitHub issue
  * Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  * Set status as CLOSED MOVED

All issues that remain open will be automatically closed in the next few weeks. Then
the Bugzilla component for GMF Notation will be archived and made read-only.
Comment 5 Pierre-Charles David CLA 2023-02-05 11:15:51 EST
Closing as part of the move to GitHub.
Feel free to re-open an equivalent issue at https://github.com/eclipse/gmf-notation/issues if you feel this is still relevant.