Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314903 - [JSF2.0] Facelet validator should only validate facelet content type files
Summary: [JSF2.0] Facelet validator should only validate facelet content type files
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC4   Edit
Assignee: JSF Project Core CLA
QA Contact:
URL:
Whiteboard: PMC_approved JSF2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 12:06 EDT by Cameron Bateman CLA
Modified: 2010-06-02 11:07 EDT (History)
4 users (show)

See Also:
cameron.bateman: pmc_approved?
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
deboer: pmc_approved+
raghunathan.srinivasan: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
raghunathan.srinivasan: review+

Attachments
Changes the validator criteria to the Facelet content type. Also changes the id of the Facelet content types to the recommended fully qualified format. (5.54 KB, patch)
2010-05-28 12:08 EDT, Cameron Bateman CLA 		no flags Details | Diff
Broken out just the validator part of the patch. Move the rest to blocking bug. (893 bytes, patch)
2010-05-28 15:27 EDT, Cameron Bateman CLA 		no flags Details | Diff
Same patch but with the current content type id used for Facelets. (860 bytes, patch)
2010-06-01 14:19 EDT, Cameron Bateman CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Bateman CLA 2010-05-28 12:06:04 EDT 
Currently the validator for Facelets validates all html files in >= JSF2.0 project.  This could cause significant performance problems in the projects that have large numbers of HTML files that are not involved with Facelets.
Comment 1 Cameron Bateman CLA 2010-05-28 12:08:19 EDT 
Created attachment 170373 [details]
Changes the validator criteria to the Facelet content type.  Also changes the id of the Facelet content types to the recommended fully qualified format.
Comment 2 Yury Kats CLA 2010-05-28 14:50:54 EDT 
There is a separate bug open for content type ID prefix. See bug 314178.
I suggest tracking the two issues separately, as adopters would need to react to ID change, and it's hard to monitor when IDs are being changed under covers of a different issue.
Comment 3 Cameron Bateman CLA 2010-05-28 15:27:17 EDT 
Created attachment 170419 [details]
Broken out just the validator part of the patch.  Move the rest to blocking bug.
Comment 4 Raghunathan Srinivasan CLA 2010-05-28 20:06:30 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
This is a stop-ship bug. For projects with JSF 2.0 facets, this bug will result in bad performance since the JSF Validator will validate all html files in the project and not just those that have JSF 2.0 tags.
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
No reasonable workaround
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Code review and manual testing.
* Give a brief technical overview. Who has reviewed this fix? 
See comment 1
* What is the risk associated with this fix?
low-medium
Comment 5 David Williams CLA 2010-05-28 23:31:15 EDT 
Sounds like an important fix. Can you make it using the "old" contentType IDs?
Comment 6 Raghunathan Srinivasan CLA 2010-06-01 11:23:15 EDT 
We will redo the patch with existing content type id.
Comment 7 Cameron Bateman CLA 2010-06-01 14:19:25 EDT 
Created attachment 170671 [details]
Same patch but with the current content type id used for Facelets.
Comment 8 Cameron Bateman CLA 2010-06-02 11:07:57 EDT 
Patch applied to HEAD (3.2RC4).