Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314868 - Create category for SystemTap views
Summary: Create category for SystemTap views
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Systemtap (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6   Edit
Assignee: anithra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 09:48 EDT by Andrew Overholt CLA
Modified: 2010-06-01 10:17 EDT (History)
2 users (show)

See Also:

Attachments
illustrative screenshot (12.51 KB, image/png)
2010-05-28 09:48 EDT, Andrew Overholt CLA 		no flags Details
proposed patch (7.55 KB, patch)
2010-05-28 15:02 EDT, Andrew Overholt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2010-05-28 09:48:09 EDT 
There are a bunch of SystemTap views with no category.  They therefore show up under "Other" in the Show View dialog.  We should add a category for them.
Comment 1 Andrew Overholt CLA 2010-05-28 09:48:42 EDT 
Created attachment 170342 [details]
illustrative screenshot

Screenshot showing all uncategorized views.
Comment 2 Andrew Overholt CLA 2010-05-28 15:02:09 EDT 
Created attachment 170414 [details]
proposed patch

Here's a patch that adds a category to org.eclipse.systemtap.ui.structures (a common root plugin for all those SystemTap ones contributing views) and then adds the other views to it.

Anithra, can you please review?
Comment 3 Andrew Overholt CLA 2010-05-28 15:03:14 EDT 
Roland, I'd also appreciate a review from you since it's so late in the release cycle.
Comment 4 Roland Grunberg CLA 2010-05-28 15:28:31 EDT 
This works for me. All SystemTap views formerly under 'Other' now appear under a 'SystemTap' category.
Comment 5 Andrew Overholt CLA 2010-05-28 16:23:45 EDT 
Thanks.  I'll give Anithra until Tuesday to take a look but it's important enough to commit even without her +1 if it comes to that.
Comment 6 anithra CLA 2010-06-01 04:00:11 EDT 
Thanks Andrew. It looks good to me.
Comment 7 Andrew Overholt CLA 2010-06-01 10:17:43 EDT 
Patch committed (Subversive doesn't seem to show me the revision number).