Community
Participate
Working Groups
Build Identifier: TPTP-4.7.0-201005251601 If user creates a new JUnit/JUnit Plugin test, add 2 test methods and invocations to it, add a Thread.sleep(5000l); to the first test method code and run the test, upon finishing, the start time and the end time appear to be the same on the test log. but if user switches the invocations around(second test method runs first) and run it again, the start/end time have a 5 sec difference. Reproducible: Always
This is caused by test log view deriving the start and stop dates/times from the first the last verdict events. In this case, the first verdict event is generated after the first test case is fully executed, that is after the sleep. The fix is to derive the start and stop dates/times from the first and last events, irrespective of their type.
Work-around: See the time stamps of the first and last events or the message in the last stop event for the total execution time.
Created attachment 170334 [details] Patch.
Jerome, please review the attached patch.
Added two new test cases to the following test suites: /org.eclipse.hyades.test.ui.logViewer.tests/manual/Test.UI.FrameworkEditors_logViewer_linux.testsuite /org.eclipse.hyades.test.ui.logViewer.tests/manual/Test.UI.FrameworkEditors_logViewer_windows.testsuite
Patch looks good
Requesting PMC approval for TPTP 4.7.0: 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? The start and stop time stamps in the Test Log view are incorrect. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No. 4. Does this require new API? No. 5. Who performed the code review? Jerome Bozier 6. Is there a test case attached to the bugzilla record? Added two new test cases to the following test suites: /org.eclipse.hyades.test.ui.logViewer.tests/manual/Test.UI.FrameworkEditors_logViewer_linux.testsuite /org.eclipse.hyades.test.ui.logViewer.tests/manual/Test.UI.FrameworkEditors_logViewer_windows.testsuite 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? This is caused by test log view deriving the start and stop dates/times from the first the last verdict events. In this case, the first verdict event is generated after the first test case is fully executed, that is after the sleep. The fix is to derive the start and stop dates/times from the first and last events, irrespective of their type. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No.
The attached patch and test suites are checked in to CVS (HEAD).
verified in TPTP-4.7.0-201006011014
(In reply to comment #9) > verified in TPTP-4.7.0-201006011014 Closing
