Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314800 - 3 missing 'providerNames' in XSL bundles
Summary: 3 missing 'providerNames' in XSL bundles
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsl (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.2 RC4   Edit
Assignee: David Carver CLA
QA Contact: David Carver CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 00:51 EDT by David Williams CLA
Modified: 2010-06-03 13:42 EDT (History)
3 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved+
thatnitind: pmc_approved? (naci.dai)
thatnitind: pmc_approved? (deboer)
neil.hauge: pmc_approved+
thatnitind: pmc_approved? (kaloyan)
thatnitind: review+

Attachments
screen shot showing the 4 (14.28 KB, image/png)
2010-05-28 00:51 EDT, David Williams CLA 		no flags Details
rc3 based build (101.08 KB, image/png)
2010-05-28 12:35 EDT, David Williams CLA 		no flags Details
Adds missing bundle-localization (1.85 KB, patch)
2010-05-29 08:53 EDT, David Carver CLA 		no flags Details | Diff
Updated patch to include plugin.properties file (2.44 KB, patch)
2010-06-01 12:23 EDT, David Carver CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2010-05-28 00:51:12 EDT 
Created attachment 170294 [details]
screen shot showing the 4

In RC2 EPP Packages (both JavaScript and Java EE) there are 4 bundles that shat show the "key" instead of the provider name. The key wasn't literally 'providerName' in each case, but similar. 

These were the only 4 in the whole package :(
Comment 1 Nitin Dahyabhai CLA 2010-05-28 03:30:18 EDT 
I believe I corrected org.eclipse.wst.xml.xpath2.processor, org.eclipse.wst.xml.xpath2.processor.tests, and org.eclipse.wst.xsl.exslt.core four days ago.  I wasn't aware there was a problem with org.eclipse.wst.xsl.exslt.ui, however.  Looks like it's just missing the Bundle-Localization header.
Comment 2 David Williams CLA 2010-05-28 12:35:30 EDT 
Created attachment 170379 [details]
rc3 based build

confirmed several fixed already in RC3. Two to go.
Comment 3 David Carver CLA 2010-05-28 13:07:42 EDT 
(In reply to comment #2)
> Created an attachment (id=170379) [details]
> rc3 based build
> 
> confirmed several fixed already in RC3. Two to go.

What's the time frame.  I might have some time today or this weekend to get them done.
Comment 4 David Williams CLA 2010-05-28 14:16:31 EDT 
For RC4, next Wednesday. While not a functional issue, I think it'd be worth fixing as it effects the "professional appearance" of the software ...  if anyone ever looks at that detailed view. (So you'd have one vote :)
Comment 5 David Carver CLA 2010-05-28 14:23:12 EDT 
Okay, I'll work on it this weekend and attach a patch for review.
Comment 6 David Carver CLA 2010-05-29 08:52:20 EDT 
I actually found a total of 3 missing Bundle-Localization entries.  I'll attach a patch that corrects this.
Comment 7 David Carver CLA 2010-05-29 08:53:58 EDT 
Created attachment 170455 [details]
Adds missing bundle-localization

Adds missing bundle-localization entries in the manifest.
Comment 8 David Carver CLA 2010-05-29 08:59:33 EDT 
I've added a couple of people for review and approval.  This is a low risk change and just adds some spit and polish to the overall packaging.
Comment 9 Nitin Dahyabhai CLA 2010-06-01 11:19:21 EDT 
Looks good to me, except org.eclipse.wst.xml.xpath2.processor.sdk.doc also needed its build.properties file tweaked to include plugin.properties.
Comment 10 David Williams CLA 2010-06-01 11:57:32 EDT 
I'd like to see this fixed. As safe as any rebuild could be, and seeing the keys there in the "installation" dialog looks a little careless or sloppy. Technically, could be said to be required by Sim. Rel. requirements ... but, not sure ...
Comment 11 David Williams CLA 2010-06-01 11:58:48 EDT 
Oh, and I didn't check code ... but, the actual bundle names are missing too, not just providerNames. I assume that's for same reason, but please double check all is well with them (that the keys in manifest match keys in plugin.properties).
Comment 12 David Carver CLA 2010-06-01 12:10:17 EDT 
(In reply to comment #11)
> Oh, and I didn't check code ... but, the actual bundle names are missing too,
> not just providerNames. I assume that's for same reason, but please double
> check all is well with them (that the keys in manifest match keys in
> plugin.properties).

Yes this was missing because of the missing Bundle-Localization header.
Comment 13 David Carver CLA 2010-06-01 12:23:51 EDT 
Created attachment 170654 [details]
Updated patch to include plugin.properties file

This updates the patch to include the missing plugin.properties file entry in the build.properties file
Comment 14 Nitin Dahyabhai CLA 2010-06-01 16:05:12 EDT 
Releasing on +1/-0.
Comment 15 Nitin Dahyabhai CLA 2010-06-02 19:42:44 EDT 
Resolving.