Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314772 - Remove build.properties file from org.eclipse.tptp.monitoring.runtime feature
Summary: Remove build.properties file from org.eclipse.tptp.monitoring.runtime feature
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sean Lamers CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 16:13 EDT by Sean Lamers CLA
Modified: 2016-05-05 10:38 EDT (History)
2 users (show)

See Also:
kathy: pmc_approved? (oec)
kathy: pmc_approved? (ernest)
kathy: pmc_approved+
paulslau: pmc_approved+
kathy: pmc_approved? (jgwest)
jcayne: review+

Attachments
Patch - remove build.properties (621 bytes, patch)
2010-05-27 16:17 EDT, Sean Lamers CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Lamers CLA 2010-05-27 16:13:18 EDT 
The feature org.eclipse.tptp.monitoring.runtime contains an unnecessary build.properties file. This file should be removed before moving Monitoring to as-is.
Comment 1 Sean Lamers CLA 2010-05-27 16:17:34 EDT 
Created attachment 170262 [details]
Patch - remove build.properties

Patch to remove the build.properties file from the org.eclipse.tptp.monitoring.runtime feature.
Comment 2 Sean Lamers CLA 2010-05-27 16:18:53 EDT 
Joel, please review.
Comment 3 Sean Lamers CLA 2010-05-27 16:31:11 EDT 
I am requesting PMC approval to include the fix for this defect in TPTP 4.7.0:

1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?
This defect does not affect functionality. The fix will remove an unnecessary build.properties file from the Monitoring Project packaging before it is moved to As-Is in TPTP 4.7.0.

2. Is there a work-around? If so, why do you believe the work-around is insufficient?
No.

3. Is this a regression or API breakage? Explain.
No.

4. Does this require new API?
No.

5. Who performed the code review?
Joel.

6. Is there a test case attached to the bugzilla record?
No.

7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix?
The build.properties file will be removed from the org.eclipse.tptp.monitoring.runtime feature. This is low risk.

8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?
No.
Comment 4 Joel Cayne CLA 2010-05-27 16:33:41 EDT 
Patch looks good.
Comment 5 Kathy Chan CLA 2010-05-27 17:00:06 EDT 
Requesting PMC approval for TPTP 4.7.
Comment 6 Joel Cayne CLA 2010-05-27 17:58:11 EDT 
Patch checked into HEAD.
Comment 7 Sean Lamers CLA 2010-05-28 11:57:58 EDT 
Verified in TPTP-4.7.0-201005272100.