Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314711 - Invalid characters allowed as name of test assets
Summary: Invalid characters allowed as name of test assets
Status: CLOSED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 11:55 EDT by Ben Chen CLA
Modified: 2016-05-05 11:02 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Chen CLA 2010-05-27 11:55:37 EDT 
Build Identifier: TPTP-4.7.0-201005251601

related to Test.Execution.JUnitRunner
case: Bugzilla_286952

Reproducible: Always

Steps to Reproduce:
1.In the overview section of a test asset, change its name to contain any of the following: "!", "*", "(", ")"
2.Notice that the action is granted and the test asset is saved with the invalid name string
Comment 1 Ben Chen CLA 2010-05-27 11:57:44 EDT 
Paul, I recall seeing a test case covering this scenario in the Navigator test suite but cannot remember it on top of my head. If no such navigator test exists, shouldn't this test step be written as an individual navigator test instead of within the JUnit test suite?
Comment 2 Paul Slauenwhite CLA 2010-05-27 15:27:26 EDT 
(In reply to comment #1)
> Paul, I recall seeing a test case covering this scenario in the Navigator test
> suite but cannot remember it on top of my head. If no such navigator test
> exists, shouldn't this test step be written as an individual navigator test
> instead of within the JUnit test suite?

The only test suite that was removed was /org.eclipse.hyades.test.ui.navigator.tests/manual/Test.UI.TestNavigator_bugzilla_160861.testsuite:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=308686#c2
Comment 3 Paul Slauenwhite CLA 2010-05-27 15:49:13 EDT 
This is working as designed since name in the editor is the logical name (not the resource name), which is limited to the conditions of org.eclipse.hyades.test.ui.util.TestUIUtil.isLogicalNameValid(String), of which org.eclipse.hyades.ui.util.LocationValidator.validateEMFSegment(String) does not limit the !, *, (, and ) characters.  Note, the wizard validates the resource and logical names since the same name is used to create the file/logical name.
Comment 4 Ben Chen CLA 2010-06-01 15:02:21 EDT 
(In reply to comment #3)
> This is working as designed since name in the editor is the logical name (not
> the resource name), which is limited to the conditions of
> org.eclipse.hyades.test.ui.util.TestUIUtil.isLogicalNameValid(String), of which
> org.eclipse.hyades.ui.util.LocationValidator.validateEMFSegment(String) does
> not limit the !, *, (, and ) characters.  Note, the wizard validates the
> resource and logical names since the same name is used to create the
> file/logical name.

Closing