Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314685 - EModelService's findElements(MUIElement, String, Class<T>, List<String>) method can return duplicates
Summary: EModelService's findElements(MUIElement, String, Class<T>, List<String>) meth...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Eric Moffatt CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 10:44 EDT by Remy Suen CLA
Modified: 2010-05-27 11:10 EDT (History)
0 users

See Also:

Attachments
Patch to exclude duplicate entries in 'findElements' (944 bytes, patch)
2010-05-27 11:00 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-05-27 10:44:18 EDT 
I'm getting two editors in the returned list that's pointing at the same thing. The returned collection is a List and not a Set but this feels wrong.
Comment 1 Remy Suen CLA 2010-05-27 10:51:22 EDT 
This problem is very easy to reproduce.

1. Launch a clean inner.
2. Make a project and a file.
3. Open the file (if it's not already opened).
4. Switch perspectives.
5. Restart.
6. Close the file.
7. Try opening it again with Ctrl+Shift+R, it won't come back.
Comment 2 Eric Moffatt CLA 2010-05-27 11:00:54 EDT 
Created attachment 170198 [details]
Patch to exclude duplicate entries in 'findElements'
Comment 3 Remy Suen CLA 2010-05-27 11:10:16 EDT 
(In reply to comment #2)
> Created an attachment (id=170198) [details]
> Patch to exclude duplicate entries in 'findElements'

Works for me. Released to HEAD along with a test.