Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314650 - "Reassign Changes To > New Change Set..." should not collapse parents
Summary: "Reassign Changes To > New Change Set..." should not collapse parents
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 09:16 EDT by Markus Keller CLA
Modified: 2019-11-27 07:44 EST (History)
2 users (show)

See Also:


Attachments
Fix v01 (2.95 KB, patch)
2010-06-15 11:12 EDT, Tomasz Zarna CLA
no flags Details | Diff
mylyn/context/zip (152.08 KB, application/octet-stream)
2010-06-15 11:12 EDT, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-05-27 09:16:14 EDT
I20100526-1625

Non-model based synchronization. Have a few changes in the same project (e.g. format a whole package). Synchronize with HEAD. In outgoing mode, show change sets. Select a changed file and choose "Reassign Changes To > New Change Set...".

=> Now, the parent hierarchy of the originally selected file is completely collapsed. This is unnecessary and quite annoying when you try to structure your changes, since you have to expand the original project and parent folders again and again.
Comment 1 Markus Keller CLA 2010-05-27 09:34:43 EDT
Does not happen all the time. Concrete example where it happens:
- check out org.eclipse.jdt.core
- format source folder 'antadapter'
- expand all
- select JDTCompilerAdapter.java
- "Reassign Changes To > New Change Set...", call it "d"
=> antadapter/org/eclipse/jdt/core is collapsed

I've also seen examples where the whole parent chain including the project was collapsed.
Comment 2 Tomasz Zarna CLA 2010-06-15 11:12:44 EDT
Created attachment 171948 [details]
Fix v01

Quick and dirty patch which seems to fix the issue. Please note, I didn't check how does it work for scenario described on bug 79909, which added the check removed here. Do not commit.
Comment 3 Tomasz Zarna CLA 2010-06-15 11:12:49 EDT
Created attachment 171949 [details]
mylyn/context/zip
Comment 4 Tomasz Zarna CLA 2010-06-15 11:14:26 EDT
(In reply to comment #2)
>  described on bug 79909

I meant bug 79908.
Comment 5 Tomasz Zarna CLA 2010-06-16 05:11:32 EDT
Isn't it a dupe of bug 185907?
Comment 6 Markus Keller CLA 2010-06-16 08:29:07 EDT
(In reply to comment #5)
> Isn't it a dupe of bug 185907?

Could be, but in contrast to bug 185907, this bug has steps to reproduce. If this is really is a problem in the TreeViewer, then a fix in JFace would of course be better.
Comment 7 Lars Vogel CLA 2019-11-27 07:44:51 EST
This bug hasn't had any activity in quite some time. Maybe the problem got
resolved, was a duplicate of something else, or became less pressing for some
reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it.
The information can be, for example, that the problem still occurs, that you
still want the feature, that more information is needed, or that the bug is
(for whatever reason) no longer relevant.

If the bug is still relevant, please remove the stalebug whiteboard tag.