Community
Participate
Working Groups
Only for the first workbench window, the button is missing. From the second window onwards it comes correctly. Looks like a regression in 3.6, in earlier versions it works fine.
Created attachment 170153 [details] Patch v01
The issue is because when the CocoaUIEnhancer looks at the window the Intro part is opened, and no toolbar/perspective bar is shown. So it doesn't add the button. I'm adding the button if the toolbar is shown after the creation of the window. Please review.
I'm going to let Oleg review, he's more familiar with a Mac. PW
Could somebody (Oleg?) please investigate what caused the regression? I would like to see this fixed but am hoping that we can find a smaller fix with hopefully less risk of getting it wrong.
From what I see, the problem only manifests if the "Welcome" view was maximized at the time Eclipse started up. In all other cases the button seems to appear fine. I see the same behaviour with Eclipse 3.5.2, so this is not a regression. As the problem existed before and did not cause any concern at least since 3.5.2, I suggest we fix this is 3.7.
(In reply to comment #5) > From what I see, the problem only manifests if the "Welcome" view was maximized > at the time Eclipse started up. To be more precise: the problem is that button is only added on startup, and only if there is a visible toolbar. However, toobar can be shown or hidden later and there does not seem to be a corresponding tracker for those events. (For instance, the other way to duplicate the problem is to hide the toolbar, restart Eclipse, and "show toolbar" after restart - the button won't appear with or without the patch.)
(In reply to comment #5) > I see the same behaviour with Eclipse 3.5.2, so this is not a regression. > > As the problem existed before and did not cause any concern at least since > 3.5.2, I suggest we fix this is 3.7. +1
Ok. If it isn't a regression, then no need to hurry :-) Moving for 3.7
Patch v01 released to HEAD
Verified in I20101025-1800
