Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314609 - Theme switching in Contact doesn't work in Eclipse e4 M6 build
Summary: Theme switching in Contact doesn't work in Eclipse e4 M6 build
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 03:23 EDT by Lars Vogel CLA
Modified: 2010-05-28 12:22 EDT (History)
4 users (show)

See Also:


Attachments
Theme (18.64 KB, image/gif)
2010-05-27 03:23 EDT, Lars Vogel CLA
no flags Details
Toolbar (6.04 KB, image/gif)
2010-05-27 16:34 EDT, Lars Vogel CLA
no flags Details
Toolbar css problem (2.22 KB, image/gif)
2010-05-28 11:52 EDT, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2010-05-27 03:23:57 EDT
Created attachment 170141 [details]
Theme

Start contact and select Theme -> Bright Theme and you receive the result of the screenshot.
Comment 1 Thomas Schindl CLA 2010-05-27 10:44:09 EDT
Looks like a problem i introduced with the gradient optimization
Comment 2 Thomas Schindl CLA 2010-05-27 10:59:01 EDT
Thanks for the report Lars, fixed in CVS
Comment 3 Lars Vogel CLA 2010-05-27 16:34:55 EDT
Created attachment 170266 [details]
Toolbar

Almost perfect, thank you for the fast fix. The toolbar seems to have still a problem. See screenshot.
Comment 4 Lars Vogel CLA 2010-05-27 16:35:14 EDT
See comment above
Comment 5 Thomas Schindl CLA 2010-05-27 20:32:32 EDT
I don't think that my performance fix introduced this problem - but I'll investigate.
Comment 6 Thomas Schindl CLA 2010-05-28 07:04:11 EDT
Ok it think once more the problem is my optimization code because I don't regenerate the image because the size is already correct.

Bogdan is it possible that the background-stuff is not working on cocoa-Toolbars? On my cocoa install i see the background of the shell shinging through?

Beside that I think I found a problem general problem in the CSS-Code when switching themes (it doesn't only apply on Gradients but also on Colors, Fonts, ...).

The problem is that if one CSS is coming with a gradient and another CSS is not we don't reset the image to NULL.

Lars can you test it and close the bug as resolved if the fix I just checked in solves the problem?
Comment 7 Lars Vogel CLA 2010-05-28 11:52:32 EDT
Created attachment 170370 [details]
Toolbar css problem

Looks good. 

There is still the old problem that the toolbar is not initially styled completely (see screenshot). But this is an older bug, therefore it might be tracked somewhere else already. If there is already a bug for this I believe this one can get closed. 

The null problem might be the problem from https://bugs.eclipse.org/bugs/show_bug.cgi?id=308940
Comment 8 Thomas Schindl CLA 2010-05-28 12:22:39 EDT
thanks