Community
Participate
Working Groups
Build Identifier: I20100513-1500 This refactoring removes the labels that are not longer referenced by any statement. If the statement is a Continue statement , the Continue stmt is removed from the code. Reproducible: Always
Created attachment 170125 [details] the patch
Thanks, Mariano. Can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files?
I confirm that 1. I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. I have the right to contribute the code to Eclipse, and 3. I have included the EPL license header in all source files Mariano Mendez
CQ 4178 submitted
Created attachment 171185 [details] compliant with Eclipse Helios rc2
Hi Mariano, I've been in contact with the IP team. They will be contacting Alejandra regarding copyright issues. They would like you to make the following change: 1. The last line should read "Mariano Mendez - Initial API and implementation" Please revise the patch accordingly, and I'll submit the revised version to the IP team. Thanks.
Created attachment 172181 [details] legal issue fixed
Thanks. I attached the revised patch to the CQ. Sharon will process the CQ as soon as she receives confirmation from your University that the copyright belongs to you.
The CQ was approved. I will try to get this into CVS soon.
Created attachment 174356 [details] Revised patch - changed Reindenter package, added replace to test case class
Esfar, could you please convert the test suite for this refactoring to be marker-based and then attach a revised patch? It looks like he expects the second test case to fail its initial(?) precondition check, and the other two should pass. Thanks.
Created attachment 174432 [details] Marker based test suite for for Remove Unreferenced Labels refactoring
Quick note, I'm not sure at the moment as to why test case #2 does not seem to work. It seems to expect an initial precondition failure, but I can't see why one would occur. Also, test case #3 no longer seems to be refactored in marker-based style.
Created attachment 174451 [details] (NEW) Marker-based test suite for Remove Unreferenced Label refactoring Correct patch. Issues in the last patch resulted from me not separating test files into individual folders.
Thanks. Esfar, for your test suite code, can you please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests), 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files?
(In reply to comment #15) > Thanks. Esfar, for your test suite code, can you please confirm that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others (except for code from Mariano's > original tests), > > 2. you have the right to contribute the code to Eclipse, and > > 3. you have included the EPL license header in all source files? Yes, 1. I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests), 2. I have the right to contribute code to Eclipse, and 3. I have included the EPL license header in all source files
Committed to CVS HEAD. Thanks, Mariano and Esfar.
