Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314575 - Add manifest entry page of module project should not list files in lib dir of its EAR
Summary: Add manifest entry page of module project should not list files in lib dir of...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 17:30 EDT by Aidyl Kareh CLA
Modified: 2010-05-27 17:36 EDT (History)
5 users (show)

See Also:
david_williams: pmc_approved+
amkareh: pmc_approved? (raghunathan.srinivasan)
amkareh: pmc_approved? (naci.dai)
deboer: pmc_approved+
amkareh: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
cbridgha: review+
jsholl: review+

Attachments
Proposed Patch (3.47 KB, patch)
2010-05-26 17:34 EDT, Aidyl Kareh CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-05-26 17:30:08 EDT 
Build Identifier: WTP 3.2

If you go to a Java EE (5 or 6) module's 'Deployment Assembly' preference page -> 'Manifest Entries' tab -> select the 'Add...' button, the list of files that can be added to the MANIFEST file shows .jars that are inside the library directory of the EAR that contains the project. These entries should not be included for EE5 and EE6.

Reproducible: Always

Steps to Reproduce:
1. Create EAR project (5 or 6) with all default modules
2. Create a java project
3. Open the deployment assembly page for the EAR, and add a reference to the java project (the project will be added to the lib directory)
4. Now open the deployment assembly page of other project (i.e. the web project), go to the manifest entries tab, and click on Add
5. The project you added to the EAR is available to be added as entry to the manifest
Comment 1 Aidyl Kareh CLA 2010-05-26 17:34:12 EDT 
Created attachment 170106 [details]
Proposed Patch

This patch modifies the JEEManifestDiscerner.trimEarHardRefs() method so that .jar references in the EAR's library directory are not added for EE5/EE6 projects.
Comment 2 Jason Sholl CLA 2010-05-26 17:48:40 EDT 
Chuck, please put up for PMC after you review.
Comment 3 Chuck Bridgham CLA 2010-05-27 10:16:36 EDT 
I approve
Comment 4 Aidyl Kareh CLA 2010-05-27 13:57:33 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a
"hotbug" (requested by an adopter) please document it as such. 

The contents of the EAR's library directory are accessible to modules by default. Thus, .jar files that are in the library directory folder of the EAR shouldn't be included as options that the module can add to its MANIFEST file.

    * Is there a work-around? If so, why do you believe the work-around is
insufficient? 

No

    * How has the fix been tested? Is there a test case attached to the
bugzilla record? Has a JUnit Test been added? 

Tested with UI.

    * Give a brief technical overview. Who has reviewed this fix? 

Check if the EAR's version is java EE5/EE6, and if so, .jar references in the EAR's library directory are not included in the list of files that can be added to the MANIFEST file of modules. This patch has been reviewed by Chuck and Jason.

    * What is the risk associated with this fix? 

No
Comment 5 Carl Anderson CLA 2010-05-27 14:35:05 EDT 
Committed to HEAD for WTP 3.2 RC3