Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314564 - [tcf][patch] org.eclipse.tm.tcf.core.AbstractChannel#write() mangles binary data
Summary: [tcf][patch] org.eclipse.tm.tcf.core.AbstractChannel#write() mangles binary data
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 0.3   Edit
Assignee: Project Inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 15:59 EDT by Ed Swartz CLA
Modified: 2013-06-05 06:26 EDT (History)
2 users (show)

See Also:

Attachments
patch (595 bytes, patch)
2010-05-26 16:00 EDT, Ed Swartz CLA 		eugene: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Swartz CLA 2010-05-26 15:59:50 EDT 
We're implementing a custom channel from AbstractChannel and when using the filesystem service and a binary payload, we found that our channel implementation was cutting off messages unexpectedly.  

It looks like a simple Java coding error in #write(byte[]) -- since bytes are sign extended when passed as int, a few of these will look like MARKER_EOM and MARKER_EOS.
Comment 1 Ed Swartz CLA 2010-05-26 16:00:39 EDT 
Created attachment 170091 [details]
patch
Comment 2 Eugene Tarassov CLA 2010-05-26 17:16:36 EDT 
I have committed the fix.
Thanks!
Comment 3 Martin Oberhuber CLA 2010-05-28 14:09:00 EDT 
Bulk update: Marking all TCF fixes from the Helios period (2009-06-29 until 2010-06-01) as target 3.2 since they go through release review along with the TM 3.2 release.
Comment 4 Doug Schaefer CLA 2011-05-17 10:49:25 EDT 
Moving bugs to new home for IP log.
Comment 5 Martin Oberhuber CLA 2013-06-05 06:26:50 EDT 
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3