Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314561 - Add missing help contexts
Summary: Add missing help contexts
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Doc (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.6 RC3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 310469 310493
  Show dependency tree
 
Reported: 2010-05-26 15:43 EDT by Curtis Windatt CLA
Modified: 2010-05-26 22:15 EDT (History)
4 users (show)

See Also:
darin.eclipse: review+
ankur_sharma: review+
john.arthorne: review+

Attachments
Fix (5.29 KB, patch)
2010-05-26 15:54 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-05-26 15:43:59 EDT 
There are missing contexts on two dialogs in PDE.  We need to add the contexts so we can add context sensitive help doc.
Comment 1 Curtis Windatt CLA 2010-05-26 15:44:57 EDT 
The two contexts are for the target export wizard and the import plug-in from cvs detailed page.
Comment 2 Curtis Windatt CLA 2010-05-26 15:54:01 EDT 
Created attachment 170088 [details]
Fix
Comment 3 Curtis Windatt CLA 2010-05-26 15:54:37 EDT 
Darin, Ankur, Dani, please review as soon as you are able.
Comment 4 Ankur Sharma CLA 2010-05-26 16:09:36 EDT 
+1
Comment 5 Darin Wright CLA 2010-05-26 16:15:03 EDT 
For the CVS wizard page, should the help be registered on the local "comp" or the passed in "parent" composite? (For the other import wizard pages, the local composite container is used).
Comment 6 Curtis Windatt CLA 2010-05-26 16:37:42 EDT 
(In reply to comment #5)
> For the CVS wizard page, should the help be registered on the local "comp" or
> the passed in "parent" composite? (For the other import wizard pages, the local
> composite container is used).

It shouldn't matter in this case as the locally create composite simply fills the parent composite.  The fix can be easily changed to use the local comp.
Comment 7 Curtis Windatt CLA 2010-05-26 17:04:31 EDT 
Dani is out for the day, adding John A instead.
Comment 8 Curtis Windatt CLA 2010-05-26 22:15:12 EDT 
Fixed in HEAD.  Thanks John.