Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314524 - Accept Heap Instance data requests only when enabled
Summary: Accept Heap Instance data requests only when enabled
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Joel Cayne CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 314543
  Show dependency tree
 
Reported: 2010-05-26 12:57 EDT by Joel Cayne CLA
Modified: 2016-05-05 11:09 EDT (History)
2 users (show)

See Also:
kathy: pmc_approved? (oec)
kathy: pmc_approved? (ernest)
kathy: pmc_approved? (kathy)
kathy: pmc_approved? (paulslau)
jgwest: pmc_approved+

Attachments
Patch to ACCollector (6.87 KB, patch)
2010-05-26 12:57 EDT, Joel Cayne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Cayne CLA 2010-05-26 12:57:36 EDT 
Created attachment 170049 [details]
Patch to ACCollector

A request for heap instance data collection should not be handled when the option is not enabled.

The attached patch checks if the option has been enabled.

Mike,
Can you please review?
Thanks!
Comment 1 Mike Reid CLA 2010-05-26 13:22:49 EDT 
Patch looks good.
Comment 2 Joel Cayne CLA 2010-05-26 13:56:16 EDT 
I would like to request for PMC approval to include the fix of this bug in TPTP
v4.7.0.

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

This updates the heap instance data collection request command to send a response only when the option for this extension has been enabled.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

3. Is this a regression or API breakage? Explain.

No.

4. Does this require new API?

No.

5. Who performed the code review?

Mike

6. Is there a test case attached to the bugzilla record?

No. A test case will be added as part of bug 314543.

7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Low.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
n/a
Comment 3 Kathy Chan CLA 2010-05-26 14:29:07 EDT 
Requesting PMC approval for TPTP 4.7.
Comment 4 Joel Cayne CLA 2010-05-26 14:48:15 EDT 
Patch checked into HEAD.
Comment 5 Joel Cayne CLA 2010-06-11 12:18:44 EDT 
Closing.