Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314516 - WTP defect verification test test184154 fails because EJBProjectCreationDataModelVerifier.verifyClient() uses ejbClientName to verify manifest reference
Summary: WTP defect verification test test184154 fails because EJBProjectCreationDataM...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 12:50 EDT by Roberto Sanchez Herrera CLA
Modified: 2011-01-10 10:59 EST (History)
3 users (show)

See Also:
ccc: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
ccc: pmc_approved? (naci.dai)
deboer: pmc_approved+
ccc: pmc_approved? (neil.hauge)
ccc: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
EJBProjectCreationDataModelVerifier.verifyClient() uses ejb client URI instead of project name (1.48 KB, patch)
2010-05-26 12:53 EDT, Roberto Sanchez Herrera CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2010-05-26 12:50:46 EDT 
Build Identifier: I20100511-0800

The WTP defect verification test test184154 (found in org.eclipse.jst.j2ee.defect.tests.DefectVerificationTests) fails because the test case sets the EJB client URI to TestAPIEjbProjectClientzzzzz.jar (the ejb client project name is TestAPIEjbProjectClient) and later verifies that the EJB project has a reference to the client in the MANIFEST, but   org.eclipse.wtp.j2ee.headless.tests.ejb.verifiers.EJBProjectCreationDataModelVerifier.verifyClient() uses the ejb client project name instead of the URI to look for the reference into the MANIFEST.


Reproducible: Always
Comment 1 Roberto Sanchez Herrera CLA 2010-05-26 12:53:41 EDT 
Created attachment 170042 [details]
EJBProjectCreationDataModelVerifier.verifyClient() uses ejb client URI instead of project name

With this patch, EJBProjectCreationDataModelVerifier.verifyClient() will use the URI instead if the project name when checking for ejb client references in MANIFEST
Comment 2 Jason Sholl CLA 2010-05-26 14:19:15 EDT 
This is a JUnit fix only, so putting in to WTP 3.2 RC3 without PMC approval.
Comment 3 Chuck Bridgham CLA 2010-05-26 14:50:24 EDT 
This fix looks good - should use URI if available
Comment 4 Carl Anderson CLA 2010-05-26 14:57:42 EDT 
This fixes one of the JUnits that used to be in the BVT for Java EE Tools.  This bucket is still run before releasing.  The code to handle EJB Client references in EJBs was cleaned up during WTP 3.2- while this JUnit should have been fixed at that time, it has not yet been fixed.

There is no workaround.

The JUnit has been run with this fix, and it now runs properly.

The JUnit now checks to verify that the URI that was passed in for the creation is the URI that exists in the MANIFEST.MF.

The risk is very low- limited to one JUnit (that isn't even run during BVT.)