Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314499 - Don't show file location in phpdoc
Summary: Don't show file location in phpdoc
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 12:11 EDT by Jacek Pospychala CLA
Modified: 2020-05-14 11:38 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (13.14 KB, image/png)
2010-05-26 12:12 EDT, Jacek Pospychala CLA 		no flags Details
patch (7.45 KB, patch)
2010-05-27 08:14 EDT, xu jiaxi CLA 		jacek.pospychala: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2010-05-26 12:11:35 EDT 
I'm not sure why is PDT showing file locations in phpdoc.
It's useless, because Ctrl+Click on the file automatically opens it.

And it hurts users eyes if the file path is very long.
Comment 1 Jacek Pospychala CLA 2010-05-26 12:12:49 EDT 
Created attachment 170034 [details]
screenshot
Comment 2 Jacek Pospychala CLA 2010-05-26 12:13:30 EDT 
hi Xu,
want to take a look at this one too? :-)
Comment 3 Zhongwei Zhao CLA 2010-05-26 20:08:26 EDT 
Hi Jacek

I will talk to you about this two bugs later:)
Comment 4 xu jiaxi CLA 2010-05-26 22:02:55 EDT 
Hi Jacek,
Currently, we get the element name by using org.eclipse.dltk.ui.ScriptElementLabels.
I will try to fix this bug in PHP by extending ScriptElementLabels.
Comment 5 xu jiaxi CLA 2010-05-27 08:14:36 EDT 
Created attachment 170170 [details]
patch

Hi Jacek,
Here is the patch.
Comment 6 Zhongwei Zhao CLA 2010-06-01 22:52:49 EDT 
Hi Jacek

I notice two things from the patch:
1 remove the useless file location for type.
2 reorder the method label,for example:

function tt(Zend_Feed $dd=NULL) {
	;
}

the method label will be tt(Zend_Feed=NULL) or the method label will be tt(Zend_Feed $dd=NULL) ,it depends on the flag.

before is

the method label will be tt(Zend_Feed=NULL) or the method label will be tt($dd:Zend_Feed=NULL) ,it depends on the flag.

mark as fixed.
Comment 7 Gadi Goldbarg CLA 2010-06-17 08:43:07 EDT 
Verified at PDT-2.2.0.v20100616 - now phpdoc is more user friendly looking :)
Closing this issue as fixed
Thanks

Verified by
Teodor Kirkov
teodor.k@zend.com
Comment 8 Jacek Pospychala CLA 2010-06-17 08:46:34 EDT 
(In reply to comment #7)
> Verified at PDT-2.2.0.v20100616 - now phpdoc is more user friendly looking :)

yay! :-)