Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314493 - Improve phpdoc look in content assist
Summary: Improve phpdoc look in content assist
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Zhongwei Zhao CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 11:59 EDT by Jacek Pospychala CLA
Modified: 2020-05-14 13:21 EDT (History)
2 users (show)

See Also:


Attachments
screenshot (31.13 KB, image/png)
2010-05-26 12:04 EDT, Jacek Pospychala CLA
no flags Details
patch (19.58 KB, patch)
2010-05-27 10:31 EDT, xu jiaxi CLA
no flags Details | Diff
new patch (22.36 KB, patch)
2010-05-27 11:12 EDT, xu jiaxi CLA
jacek.pospychala: iplog+
Details | Diff
example (55.36 KB, image/png)
2010-06-08 07:34 EDT, Jacek Pospychala CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2010-05-26 11:59:44 EDT
PHPdocs have received lot of love recently in bug 311734 however in content assist they still look old and ugly.
It would be cool to update the way how phpdocs appear in content assist too.
Comment 1 Jacek Pospychala CLA 2010-05-26 12:04:56 EDT
Created attachment 170030 [details]
screenshot

difference between phpdoc on hover and content-assist
Comment 2 Jacek Pospychala CLA 2010-05-26 12:09:41 EDT
hi Xu,
want to take a look at this one too? :-)
Comment 3 xu jiaxi CLA 2010-05-27 10:31:44 EDT
Created attachment 170191 [details]
patch

Hi Jacek,
Here is the patch, you can try it.
Comment 4 xu jiaxi CLA 2010-05-27 11:12:01 EDT
Created attachment 170199 [details]
new patch
Comment 5 Jacek Pospychala CLA 2010-06-08 07:33:01 EDT
thanks Xu,

the patch works great for me, the improved tooltip is light years more readable. I tried it with constants/vars, functions and types and all looks fine.

I noticed only one issue, that also appears in non-CA tooltip. It's that contents of phpdoc after an empty line are not included in tooltip.
For example:

/** Line1
 *
 * Line3
 * 
 * @author jacek
 *
 */
class Boo {
	
}

hovering over Boo (or tooltip in content-assist), will show only "Line1", but not "Line3".

This is not a big issue, however, typically PDT generates phpdoc blocks like:
/**
 * 
 * Enter description here ...
 * @author jacek
 *
 */

And because of empty line, the "Enter description here..." doesn't appear in tooltip.
Comment 6 Jacek Pospychala CLA 2010-06-08 07:34:04 EDT
Created attachment 171385 [details]
example

example to above comment
Comment 7 Zhongwei Zhao CLA 2010-06-10 06:05:18 EDT
Thanks,Xu!Contributed by Xu.
Comment 8 Zhongwei Zhao CLA 2010-06-10 06:07:01 EDT
mark fixed
Comment 9 Jacek Pospychala CLA 2010-06-17 09:21:22 EDT
Regarding commen 5, I opened separate bug 317172 -  Long description missing in tooltips
Comment 10 Gadi Goldbarg CLA 2010-06-17 10:52:38 EDT
Verified at PDT-2.2.0.v20100616 
At tooltip at CA presented at the new line with mentioned issue reported by Jacek

Closing this issue...

Verified by
Teodor Kirkov
teodor.k@zend.com