Community
Participate
Working Groups
Build Identifier: 32 Following msgs are seen in the log: !ENTRY org.eclipse.osgi 2 1 2010-05-21 13:22:34.557 !MESSAGE NLS unused message: CustomWebProjectReferenceWizardFragment.0 in: org.eclipse.jst.servlet.ui.internal.messages !ENTRY org.eclipse.osgi 2 1 2010-05-21 13:22:34.573 !MESSAGE NLS unused message: CustomWebProjectReferenceWizardFragment.1 in: org.eclipse.jst.servlet.ui.internal.messages !ENTRY org.eclipse.osgi 2 1 2010-05-21 13:22:34.573 !MESSAGE NLS unused message: WebProjectReferenceDescription in: org.eclipse.jst.servlet.ui.internal.messages Reproducible: Always
Created attachment 170008 [details] patch This patch removes the unused nl strings.
approve
Simple fix to clean up the .propertes file so eclipse doesn't log unused strings. No Risk. Reviewed by Chuck.
code checked into head for wtp 3.2 rc3
This fix needs to be modified because these strings are actually being used , even though the NLS unused message is logged. These strings were being used in CustomWebProjectReferenceWizardFragment using the Messages.getString() approach instead of the standard approach of using a message bundle, which was the reason why we were getting the 'NLS Unused message' in the logs. The correct fix involves, 1. Modifying the string keys to change the .0 and .1 to _0 and _1 since the '.'s don't work in the bundle class 2. Introducing these strings in the bundle class (org.eclipse.jst.servlet.ui.internal.Messages.java) 3. Modifying CustomWebProjectReferenceWizardFragment to remove the Messages.getString() calls, and add access the strings as 'Messages.<key>' Before applying this patch (with the deleted strings added back to messages.properties), I see the following: !ENTRY org.eclipse.osgi 2 1 2010-05-27 15:37:28.515 !MESSAGE NLS unused message: CustomWebProjectReferenceWizardFragment_0 in: org.eclipse.jst.servlet.ui.internal.messages !ENTRY org.eclipse.osgi 2 1 2010-05-27 15:37:28.515 !MESSAGE NLS unused message: CustomWebProjectReferenceWizardFragment_1 in: org.eclipse.jst.servlet.ui.internal.messages !ENTRY org.eclipse.osgi 2 1 2010-05-27 15:37:28.515 !MESSAGE NLS unused message: WebProjectReferenceDescription in: org.eclipse.jst.servlet.ui.internal.messages With the patch, the above messages are gone, and the strings show up fine in the UI. New patch is attached for review.
Created attachment 170259 [details] updated patch
Clearing out the flags, setting the review for Chuck.
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. I had removed the 3 strings in the previous patch, based on the NLS unused messages - thinking these were not being used. It turned out that these strings are actually being used, even though the NLS unused message is logged. These strings were being used in CustomWebProjectReferenceWizardFragment using the Messages.getString() approach instead of the standard approach of using a message bundle, which was the reason why we were getting the 'NLS Unused message' in the logs. Without this updated patch, we see a NLS string missing messages in the Add Project Reference (with Web Library Option) deployment assembly page of the Web Project, since the UI is no longer able to find the string values. * Is there a work-around? If so, why do you believe the work-around is insufficient? No known workarounds. * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Yes this fix has been tested. Without this patch, with the strings added, I still see the following in the log: !ENTRY org.eclipse.osgi 2 1 2010-05-27 15:37:28.515 !MESSAGE NLS unused message: CustomWebProjectReferenceWizardFragment_0 in: org.eclipse.jst.servlet.ui.internal.messages !ENTRY org.eclipse.osgi 2 1 2010-05-27 15:37:28.515 !MESSAGE NLS unused message: CustomWebProjectReferenceWizardFragment_1 in: org.eclipse.jst.servlet.ui.internal.messages !ENTRY org.eclipse.osgi 2 1 2010-05-27 15:37:28.515 !MESSAGE NLS unused message: WebProjectReferenceDescription in: org.eclipse.jst.servlet.ui.internal.messages With the patch, these messages are gone, and the strings also show up properly on the UI. * Give a brief technical overview. Who has reviewed this fix? Chuck Bridgham has reviewed this patch. * What is the risk associated with this fix? There are no risks associated with the updated patch.
Committed updated patch to HEAD for WTP 3.2 RC3
