Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314473 - Move ControlDecoratorLCA to appropriate package
Summary: Move ControlDecoratorLCA to appropriate package
Status: RESOLVED WONTFIX
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 10:41 EDT by Benjamin Muskalla CLA
Modified: 2011-09-22 07:49 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-05-26 10:41:32 EDT 
ControlDecoratorLCA currently lives in org.eclipse.swt.internal.internal.widgets.controldecoratorkit and should be moved to org.eclipse.swt.internal.widgets.controldecoratorkit;
Comment 1 Ralf Sternberg CLA 2010-05-27 06:25:35 EDT 
+1, same for ControlDecoratorLCA_Test
Comment 2 Ralf Sternberg CLA 2011-09-22 07:49:19 EDT 
Although it looks like a typo, it's actually correct. The naming convention for LCAs demand that an "internal." segment is added to the package of the widget. The ControlDecorator lives in an internal package already, another "internal." segment has to be added.

If we'd change the LCA lookup code to also accept a single internal in this case we could not differentiate LCAs in the (unlikely) case that we'd have a public and an internal widget of the same name, e.g. foo.Bar and foo.internal.Bar. I think we can live with the "internal.internal" for the rare case of internal widgets.