Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314457 - JGit porcelain API should be able to report progress
Summary: JGit porcelain API should be able to report progress
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.11   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 331689 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-26 09:24 EDT by Stefan Lay CLA
Modified: 2018-02-25 12:24 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Lay CLA 2010-05-26 09:24:54 EDT
In a tool like eclipse it is a good usability standard to show the progress of a long running task to the user. Additionaly a long running task should be cancelable. 

When egit now uses the commands of the jgit porcelain API there should be a possibility to be notified about progress. 

Maybe a kind of ProgressMonitor like in eclipse could be added to a command via an additional builder method addProgressMonitor(progressMonitor). Another option would be to add a new method call(progressMonitor).
Comment 1 Chris Aniszczyk CLA 2010-05-26 10:19:03 EDT
I would prefer to just bake it in the call()... seems more intuitive that way and that in reality, I think most people are interested in progress, CLI or not.
Comment 2 Stefan Lay CLA 2010-06-01 10:16:58 EDT
There are already classes for this purpose: ProgressMonitor in JGit and EclipseGitProgressTransformer in EGit
Comment 3 Chris Aniszczyk CLA 2011-01-06 15:17:36 EST
*** Bug 331689 has been marked as a duplicate of this bug. ***
Comment 4 Daniel Weber CLA 2015-11-25 06:57:58 EST
What's the status of this? We wanted to use jgit on the command line, but checkout and reset (which can take some time) do not support reporting progress. IMHO, both commands should show progress, just as checkout and fetch do, for example.
Comment 5 Christian Halstrick CLA 2015-11-26 03:02:58 EST
The porcelain API (what is underneath org.eclipse.jgit.api) for cloning has this feature. It allows to set ProgressMonitors and EGit makes use of this. When you clone a repo with EGit then the progress is reported.

The porcelain API for checkout does not have this feature. I agree, that should be added.

Another thing is whether our command line tools (underneath org.eclipse.jgit.pgm) make use of this possibility. Clone.java has not learned to use the progress monitors to report progress. Yes, that should be added. Could you imagine to contribute?

Same for Checkout. But here the underlying command has no support for progress monitors. It has to be added to org.eclipse.jgit.pgm and JGits checkout machinery.
Comment 6 Matthias Sohn CLA 2018-02-25 12:24:55 EST
This was implemented recently in
https://git.eclipse.org/r/#/c/112855/