Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314416 - Checkboxes in disabled tables rendered incorrectly on Windows
Summary: Checkboxes in disabled tables rendered incorrectly on Windows
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 05:17 EDT by Michael Pellaton CLA
Modified: 2010-08-11 05:40 EDT (History)
4 users (show)

See Also:

Attachments
Demo application that showcases the problem (16.21 KB, application/octet-stream)
2010-05-26 05:18 EDT, Michael Pellaton CLA 		no flags Details
screenshot taken on linux gtk (18.29 KB, image/png)
2010-05-26 05:18 EDT, Michael Pellaton CLA 		no flags Details
screenshot taken on osx cocoa (25.17 KB, image/png)
2010-05-26 05:19 EDT, Michael Pellaton CLA 		no flags Details
screenshot taken on windows 7 with aero (12.45 KB, image/png)
2010-05-26 05:19 EDT, Michael Pellaton CLA 		no flags Details
screenshot taken on windows xp classic (7.56 KB, image/png)
2010-05-26 05:19 EDT, Michael Pellaton CLA 		no flags Details
Patch (preserving look for Windows XP Classic theme) (2.94 KB, patch)
2010-05-26 11:32 EDT, Felipe Heidrich CLA 		no flags Details | Diff
screenshot with the patch (22.59 KB, image/png)
2010-05-26 11:33 EDT, Felipe Heidrich CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pellaton CLA 2010-05-26 05:17:40 EDT 
Build Identifier: 3.6.RC2

The checkboxes in disabled tables are not rendered like normal disabled checkboxes in all Windows platforms. The checkboxes are functionally disabled (no checked state change possible) but they are displayed like active checkboxes. However, normal checkboxes that are not part of a table are rendered differently when disabled.

Linux/GTK and OSX/Cocoa are ok.

Based on the mail template app, I created a showcase app to display the differences (see attachment).

Please see attached screen shots.

Reproducible: Always

Steps to Reproduce:
1. download and import the attached project
2. run it on windows xp/vista/7 (classic or aero mode make no difference)
3. compare the rendering of the disabled checkboxes out and inside the table
Comment 1 Michael Pellaton CLA 2010-05-26 05:18:26 EDT 
Created attachment 169953 [details]
Demo application that showcases the problem
Comment 2 Michael Pellaton CLA 2010-05-26 05:18:53 EDT 
Created attachment 169954 [details]
screenshot taken on linux gtk
Comment 3 Michael Pellaton CLA 2010-05-26 05:19:13 EDT 
Created attachment 169955 [details]
screenshot taken on osx cocoa
Comment 4 Michael Pellaton CLA 2010-05-26 05:19:35 EDT 
Created attachment 169956 [details]
screenshot taken on windows 7 with aero
Comment 5 Michael Pellaton CLA 2010-05-26 05:19:54 EDT 
Created attachment 169957 [details]
screenshot taken on windows xp classic
Comment 6 Felipe Heidrich CLA 2010-05-26 10:42:53 EDT 
If we fix this problem, on windows xp classic theme, the user won't be able to tell if an item is grayed or not when the table is disabled.
Comment 7 Felipe Heidrich CLA 2010-05-26 11:32:37 EDT 
Created attachment 170017 [details]
Patch (preserving look for Windows XP Classic theme)
Comment 8 Felipe Heidrich CLA 2010-05-26 11:33:10 EDT 
Created attachment 170018 [details]
screenshot with the patch
Comment 9 Felipe Heidrich CLA 2010-05-26 11:44:17 EDT 
Not sure what is the best look for XP classic. Either way, I'll only be able to fix this after 3.6
Comment 10 Felipe Heidrich CLA 2010-08-10 14:15:18 EDT 
Fixed in HEAD > 20100810
Comment 11 Markus Keller CLA 2010-08-11 05:40:59 EDT 
Bug 322328 is for the same problem in Tree.