Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314410 - SQL Results Parameters tab should not appear when there are no parameters
Summary: SQL Results Parameters tab should not appear when there are no parameters
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: SQL Results View (show other bugs)
Version: 1.8   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.8   Edit
Assignee: Brian Payton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 04:26 EDT by Brian Payton CLA
Modified: 2010-05-26 05:05 EDT (History)
0 users

See Also:

Attachments
Patch for plugin o.e.d.sqltools.result.ui (1.23 KB, patch)
2010-05-26 04:54 EDT, Brian Payton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Payton CLA 2010-05-26 04:26:25 EDT 
In DTP 1.6 the Parameters tab of the SQL Results view did not appear when there were no parameters in the statement that was executed.  Now the Parameters tab is there all the time, for every result.  The SQL Results view should be fixed so that the Parameters tab only appears when needed.
Comment 1 Brian Payton CLA 2010-05-26 04:54:25 EDT 
Created attachment 169951 [details]
Patch for plugin o.e.d.sqltools.result.ui
Comment 2 Brian Payton CLA 2010-05-26 04:57:56 EDT 
The fix is pretty simple.  There is code in the class MultipleTabsGridSection in plugin org.eclipse.datatools.sqltools.result.ui that only displays the parameter tab if the parameters list in the result instance is null.  There was a fix elsewhere in the code that now causes the case of no parameters to be represented by an empty parameter list rather than a null parameter list.  The fix is to check for *both* null and empty parameter to determine whether or not to display the parameter tab.
Comment 3 Brian Payton CLA 2010-05-26 05:05:37 EDT 
Checked in fix, tagged to v201005261700