Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314381 - Invalid extension of MessageConsole
Summary: Invalid extension of MessageConsole
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Systemtap (show other bugs)
Version: 0.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6.1   Edit
Assignee: anithra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 313157
  Show dependency tree
 
Reported: 2010-05-25 18:40 EDT by Jeff Johnston CLA
Modified: 2010-11-03 09:34 EDT (History)
1 user (show)

See Also:
anithra: review?

Attachments
Extending IOConsole instead of MessageConsole (3.62 KB, patch)
2010-06-07 10:31 EDT, anithra CLA 		jjohnstn: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Johnston CLA 2010-05-25 18:40:40 EDT 
org.eclipse.ui.console.MessageConsole is extended by:

org.eclipse.linuxtools.systemtap.ui.consolelog.structures.ScriptConsole
org.eclipse.linuxtools.systemtap.ui.consolelog.structures.ScriptConsole2

but is marked noextend
Comment 1 anithra CLA 2010-06-07 10:31:54 EDT 
Created attachment 171268 [details]
Extending IOConsole instead of MessageConsole
Comment 2 Andrew Overholt CLA 2010-06-07 12:07:40 EDT 
Jeff, please review this patch and consider whether or not it warrants inclusion for 0.6 (I'm leaning towards no but will listen to counter proposals).
Comment 3 Jeff Johnston CLA 2010-06-07 13:02:59 EDT 
Comment on attachment 171268 [details]
Extending IOConsole instead of MessageConsole

Patch makes sense.  The MessageConsole class extends IOConsole which is extendible so this is just using it directly.  The IOConsole provides an IOConsoleOutputStream rather than a MessageConsoleOutputStream so the change to use the newIOConsoleOutputStream method also makes sense.
Comment 4 Jeff Johnston CLA 2010-06-07 13:05:15 EDT 
(In reply to comment #2)
> Jeff, please review this patch and consider whether or not it warrants
> inclusion for 0.6 (I'm leaning towards no but will listen to counter
> proposals).

The patch is sound from my investigation.  It does not warrant inclusion in 0.6 because it doesn't cause an error if it is not in immediately and it is too close to the release.  It should go into trunk after 0.6 is officially tagged.
Comment 5 Andrew Overholt CLA 2010-06-07 14:05:38 EDT 
Thanks for the analysis, Jeff.  Setting target milestone to 0.6.1.
Comment 6 anithra CLA 2010-11-03 09:34:57 EDT 
done