Community
Participate
Working Groups
Currently PsychoPath is using an Athena Builder, but due to the fact that the Plugin isn't OSGI dependent it would be good to have these as Maven artificats as well. To support both use cases, a Maven/Tycho based build would be ideal.
I've noticed that org.eclipse.wst.xml.xpath2.processor_tests.feature includes org.eclipse.test and org.eclipse.ant.optional.junit, but these don't seem to be available from a p2 repository - just from CVS. I've successfully built the feature while removing them _and_ org.junit at the same time. Any ideas on why they are added and whether it's safe to remove them?
Another question I have is regarding wst-xpath2-psychopath-SDK-N201003150839.zip and wst-xpath2-psychopath-Automated-Tests-N201003150839.zip . What are they based on - product files? It would be good to get these source files so that I can replicate the output in the Tycho build.
Let me get the Athena build running again, and you'll have a better comparison. All the source code should be in the SDKs. As for the feature, those bundles are only necessary for a basebuilder and Athena based build.
Robert another build to review is: https://build.eclipse.org/hudson/view/WTP/job/cbi-wtp-wst.xsl/222/testReport/ That contains the xsl and xpath2 tests, so should give you a good result. Basically, if you can get the tests to run, and generate the appropriate report, that is the main concern. I see from the latest test build I did from your fork, that the update site is being generated as well.
So then we have enough for a first patch? If so, I'll add the copyright headers, review the POM files again and attach a patch to the bug report.
yeah, we have enough for a first cut, and we can iterate on it going forward. Thanks for the help!
Created attachment 170464 [details] Tycho build for PsychoPath The git patch for the Tycho build is attached. Please let me know if it needs any updates.
Created attachment 170465 [details] Update to Proposed Patch Slight updates to the proposed patch.
As soon as the helios release is locked down, I'll apply and release the changes to cvs. Thanks for the work, gives me a good idea of what needs to be done for some of the other projects and components.
I've pushed a few more updates to the github repository. I found that it was out of synch with what was in Head from CVS. Also, I did a slight update to the POMs so that it uses helios instead of ganymede for the repositories. 20 of the WTP DOM tests needed newer versions of WTP that are only in helios. I'm copying over some updates for the xpath test suite inputs now, but that is taking a bit locally. Once it is complete I'll push them to github and everything should be in synch with what is in CVS.
(In reply to comment #6) > yeah, we have enough for a first cut, and we can iterate on it going forward. > Thanks for the help! Glad to help. I did not want to touch version numbers for this patch, but from a maven point of view life is much easier if all modules of a reactor build have the same version. You might want to do the same for this project.
Yeah, I found that out. :) Anyways, I have a complete build working now on the GitHub code base so you may want to pull from there. I still would like to figure out how to add Code Coverage tools like Emma and Cobertura to the build. I see some work on the tycho front for that but nothing that I can replicate easily with my very limited knowledge of Maven.
There are a few legends about Tycho being able to run tests instrumented with Emma ( http://www.sonatype.com/people/2009/06/integration-tests-with-maven-part-2-test-coverage-reports/ , http://software.2206966.n2.nabble.com/Status-on-Emma-code-coverage-for-unit-tests-in-Tycho-td4631373.html ), but I have not tried it myself. I'll have a look next week.
Working on adding this now.
This is now fixed and working. Thanks Robert! https://build.eclipse.org/hudson/view/WTP/job/cbi-wtp-wst.xsl.psychopath/
