Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314300 - [patch] [target] Edit target wizard content page should set focus to target name
Summary: [patch] [target] Edit target wizard content page should set focus to target name
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 trivial (vote)
Target Milestone: 4.5 M6   Edit
Assignee: pragya gaur CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 11:59 EDT by Curtis Windatt CLA
Modified: 2015-03-14 10:58 EDT (History)
2 users (show)

See Also:

Attachments
Focus set on target name.. (604 bytes, patch)
2014-11-14 01:45 EST, pragya gaur CLA 		no flags Details | Diff
Hi Vikas, done the changes as per the requirement. Please review and provide your valuable feedback. (1.11 KB, patch)
2015-02-05 07:56 EST, pragya gaur CLA 		no flags Details | Diff
Please review this new patch. (1.35 KB, patch)
2015-02-10 05:40 EST, pragya gaur CLA 		no flags Details | Diff
Hi, done the required changes. Please review. (1.39 KB, patch)
2015-02-10 08:41 EST, pragya gaur CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-05-25 11:59:21 EDT 
1) Open the target preference page
2) Open an existing target
Result: Focus is on the target name
3) Create a new target definition, hit next on the wizard
4) Focus stays on the back button

When creating a new target definition the first thing I will likely change is the name.  I am unlikely to want to go to the previous page.

When editing a target definition, setting focus on the name is ok, one could argue that users would rather have the locations section selected.

Any fix here should consider what will happen if the previous active tab gets stored.  Bug 272213.

For an example of how this can work, see the new java project wizard.  Pressing next brings up the java build settings wizard page, with the source tab always getting focus.
Comment 1 pragya gaur CLA 2014-11-14 01:45:07 EST 
Created attachment 248650 [details]
Focus set on target name..

Please review my change..and confirm if this is as per requirement.
Comment 2 Vikas Chandra CLA 2015-02-04 03:51:17 EST 
I think fNameText.selectAll();should be put instead.

Also when the text is changed, then this should not be called. So that needs to be modified too.
Comment 3 pragya gaur CLA 2015-02-05 07:56:37 EST 
Created attachment 250525 [details]
Hi Vikas,  done the changes as per the requirement. Please review and provide your valuable feedback.
Comment 4 Vikas Chandra CLA 2015-02-05 09:02:04 EST 
This patch does nothing. I think the behaviour should be similar to while creating component definition - the default name is selected and highlighted but when you edit the selected name, you don't select/highlight it.
Comment 5 pragya gaur CLA 2015-02-10 05:40:51 EST 
Created attachment 250652 [details]
Please review this new patch.
Comment 6 Vikas Chandra CLA 2015-02-10 07:18:00 EST 
Default name gets selected. Go back and next . Selection is gone. See "component defintion" creation wizard for instance.
Comment 7 pragya gaur CLA 2015-02-10 08:41:08 EST 
Created attachment 250670 [details]
Hi, done the required changes. Please review.
Comment 8 Vikas Chandra CLA 2015-02-11 03:36:41 EST 
Thanks Pragya . Fixed in 4.5 ( master stream ) using commit id 


https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=66ea9aaa7ddb49b6b588818a3e7fb80533720c01
Comment 9 Vikas Chandra CLA 2015-03-14 10:58:39 EDT 
verified in Version: Mars (4.5)
Build id: N20150312-2000