Community
Participate
Working Groups
Created attachment 169836 [details] Error 1. Test project documentation smoke test failures. See attached.
Created attachment 169837 [details] Error 2.
Created attachment 169841 [details] Patch.
Jerome, please review the attached patch.
reviewed and approved
1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Documentation smoke test accessibility issues and broken links. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. Regression. 4. Does this require new API? No. 5. Who performed the code review? Jerome Bozier 6. Is there a test case attached to the bugzilla record? Covered by existing test cases. 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Fix accessibility issues and broken links. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No.
The attached patch is checked in to CVS (HEAD).
See: http://download.eclipse.org//tptp/4.7.0/dev/TPTP-4.7.0-201005222133/CHKPII/bad/CHKPII-plugin-org.eclipse.hyades.test.doc.user.txt
Created attachment 169856 [details] Patch (Part 2).
Joel, please review patch (part 2).
Patch looks good.
Resubmitting for the attached patch (part 2): 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Documentation smoke test CHKPII issues. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. Regression. 4. Does this require new API? No. 5. Who performed the code review? Joel Cayne 6. Is there a test case attached to the bugzilla record? Covered by existing test cases. 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Fix CHKPII issues. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No.
(In reply to comment #8) > Created an attachment (id=169856) [details] > Patch (Part 2). Reviewed and approved.
Fixing flag state. The attached patch (part 2) is checked in to CVS (HEAD).
There is an error being reported in the translatability report of the latest build: http://download.eclipse.org//tptp/4.7.0/dev/TPTP-4.7.0-201005251900/CHKPII/bad/CHKPII-plugin-org.eclipse.hyades.test.doc.user.txt
Created attachment 170066 [details] Patch (Part 3).
(In reply to comment #14) > There is an error being reported in the translatability report of the latest > build: > http://download.eclipse.org//tptp/4.7.0/dev/TPTP-4.7.0-201005251900/CHKPII/bad/CHKPII-plugin-org.eclipse.hyades.test.doc.user.txt These errors are caused by the wrong DOCTYPE: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN"> --> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"> Joel, can you please review the attached patch (part 3).
Tested locally on the translation tool and the patch looks good.
Resubmitting for the attached patch (part 3): 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Documentation smoke test CHKPII issues. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. Regression. 4. Does this require new API? No. 5. Who performed the code review? Joel Cayne 6. Is there a test case attached to the bugzilla record? Covered by existing test cases. 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Fix CHKPII issues. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No.
+1 for patch #3.
(In reply to comment #19) > +1 for patch #3. The attached patch checked in to CVS (HEAD).
Verified in TPTP-4.7.0-201005251601. Closing.
