Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314278 - [preferences] Abbreviate package names: improve label and add help to Appearance pref doc
Summary: [preferences] Abbreviate package names: improve label and add help to Appeara...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.5 RC3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 10:16 EDT by Dani Megert CLA
Modified: 2010-05-28 03:03 EDT (History)
2 users (show)

See Also:
daniel_megert: review+
markus.kell.r: review+
deepakazad: review+


Attachments
Fix (1.82 KB, patch)
2010-05-26 06:43 EDT, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-05-25 10:16:17 EDT
3.6 RC2.

Abbreviate package names: improve label and add help to Appearance pref doc.
Comment 1 Dani Megert CLA 2010-05-25 10:17:46 EDT
It's not fully clear to what "matches" relates. In a chat Markus suggested:
 "must be a complete package name"
Comment 2 Deepak Azad CLA 2010-05-25 13:33:02 EDT
I think the only confusion (at least for me) in the label is whether wildcards are supported or not. 
For ex: I had tried to use the rule *.jdt={JDT}  :)

'Left side of pattern must match whole package name' 
may be replaced with
'Left side of pattern must match whole package name, wildcards are not supported'.
Comment 3 Dani Megert CLA 2010-05-26 02:39:24 EDT
>I think the only confusion (at least for me) in the label is whether wildcards
>are supported or not. 
Haha! Same here and then Markus pointed me to the sentence with the "matches" ;-)

I would not use the term "match".
Comment 4 Markus Keller CLA 2010-05-26 06:43:53 EDT
Created attachment 169964 [details]
Fix

> 'Left side of pattern must match whole package name, wildcards are not
> supported'.

That's too long, people already don't read the current label. We should remove 'pattern' and 'matches'. Then, we don't even have to repeat that a package name is a name and not a pattern.
Comment 5 Deepak Azad CLA 2010-05-26 08:20:16 EDT
(In reply to comment #4)
> That's too long, people already don't read the current label. We should remove
> 'pattern' and 'matches'. Then, we don't even have to repeat that a package name
> is a name and not a pattern.
Agree :)
Comment 6 Dani Megert CLA 2010-05-27 03:23:03 EDT
Fix looks almost good to me. When looking at it in the UI I found the mass of special chars irritating ('{JDT}.ui'; '#') and hard to read. Committed the following to HEAD:

Newline separated 'package_name=abbreviation' style abbreviation rules (e.g. rule 'org.eclipse.jdt={JDT}' will abbreviate 'org.eclipse.jdt.ui' to '{JDT}.ui').
Use '#' at beginning disables a rule:
Comment 7 Markus Keller CLA 2010-05-27 05:19:38 EDT
> Use '#' at beginning disables a rule:
Fixed typo in head (disables -> to disable).
Comment 8 Deepak Azad CLA 2010-05-27 05:28:22 EDT
Looks good now.
Comment 9 Dani Megert CLA 2010-05-28 03:03:45 EDT
Verified in I20100527-1700.