Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314253 - Linker warning not recognized
Summary: Linker warning not recognized
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 7.0   Edit
Assignee: Andrew Gvozdev CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 08:19 EDT by Axel Mueller CLA
Modified: 2010-05-27 10:54 EDT (History)
0 users

See Also:

Attachments
take preceding path into account (2.04 KB, patch)
2010-05-25 16:08 EDT, Axel Mueller CLA 		no flags Details | Diff
take preceding path into account, simple version (2.01 KB, patch)
2010-05-26 17:53 EDT, Axel Mueller CLA 		angvoz.dev: iplog+
Details | Diff
testcases (1.67 KB, text/plain)
2010-05-26 17:55 EDT, Axel Mueller CLA 		angvoz.dev: iplog+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Mueller CLA 2010-05-25 08:19:44 EDT 
The new error parser for the linker does not find the following warning:
/usr/bin/ld: warning: libstdc++.so.5, needed by /home/amueller/sources/lib/testlib.so, may conflict with libstdc++.so.6

The preceding path seems to be the problem.
RegExp: ld(\.exe)?: [Ww]arning:? (.*)
Comment 1 Andrew Gvozdev CLA 2010-05-25 09:27:47 EDT 
OK, it seems we should account for the path of ld. Is a patch coming?
Comment 2 Axel Mueller CLA 2010-05-25 16:08:57 EDT 
Created attachment 169893 [details]
take preceding path into account

This patch will take a preceding path (Linux or Windows style) into account.
Comment 3 Andrew Gvozdev CLA 2010-05-25 17:58:43 EDT 
(In reply to comment #2)
> Created an attachment (id=169893)
> take preceding path into account
> This patch will take a preceding path (Linux or Windows style) into account.

Here are some notes:
> ^(/.*/|[a-z|A-Z]:\\.*|)ld(\\.exe)?: [Ww]arning:? (.*)
- You don't need '^' in the beginning or '$' in the end. There is checking for that in the code to allow for brevity in UI.
- The second subexpression for Windows style does not work because in property file backslashes need to be doubled. Anyway, I would prefer simpler pattern like .*([/\\])?ld unless there is a real case where it clashes.
- Can you add a test case for this in GLDErrorParserTests? You would catch Windows problem if you had one :)
Comment 4 Axel Mueller CLA 2010-05-26 17:53:14 EDT 
Created attachment 170113 [details]
take preceding path into account, simple version
Comment 5 Axel Mueller CLA 2010-05-26 17:55:57 EDT 
Created attachment 170115 [details]
testcases

Here are some testcases. The original one from my first post for Linux and some tests for Windows (some of them found via Google). All tests run flawlessly on my Linux box. I don't have a Windows installation for testing :)
Comment 6 Andrew Gvozdev CLA 2010-05-26 21:30:22 EDT 
Committed on HEAD (7.0) with slight changes. Thanks, Axel.
Comment 7 CDT Genie CLA 2010-05-27 10:13:00 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 314253: Linker warning not recognized 

[*] GLDErrorParserTests.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/misc/org/eclipse/cdt/core/internal/errorparsers/tests/GLDErrorParserTests.java?root=Tools_Project&r1=1.2&r2=1.3