Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 314179 - linux tools package feature needs "linux filter"?
Summary: linux tools package feature needs "linux filter"?
Status: CLOSED DUPLICATE of bug 225365
Alias: None
Product: EPP
Classification: Technology
Component: linuxtools-package (show other bugs)
Version: 1.3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.3.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 20:51 EDT by David Williams CLA
Modified: 2010-06-11 10:33 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2010-05-24 20:51:47 EDT
If I look at /releases/helios
and try to install everything, it seems that most linux specific things are "filtered out" automatic from my selection. 

Except the linux package? At least I think it is related to that. I get error message below, and if I manually deselect that the EPP Linux tools package, I not longer get the message. 

Cannot complete the install because some dependencies are not satisfiable
  org.eclipse.linuxtools.valgrind.feature.group [0.4.0.201005172032] cannot be installed in this environment because its filter is not applicable.
Comment 1 Markus Knauer CLA 2010-05-25 03:27:28 EDT
Good point and one more thing to learn.

Do you find any other ID in the log? epp.package.linuxtools? Or org.eclipse.epp.package.linuxtools.feature? 

I hope that it is the feature that causes the problems. I've added a filter to it now (linux, gtk, x86/x86_64) and hope that it will fix the problem, but it needs a new build (of the packages and of /releases/staging) and more testing.
Comment 2 David Williams CLA 2010-05-25 03:40:23 EDT
> 
> Do you find any other ID in the log? epp.package.linuxtools? Or
> org.eclipse.epp.package.linuxtools.feature? 
> 
No, just that one. And, wasn't in the log, exactly, but just in the UI and said 'can't complete the install because following isn't for your environment". 

I think sometimes the "checking" stops on first failure, when it knows it won't install, it stops there, and tells you. So even if that once mentioned was changed/fixed, then there might be more (so, good to do at feature level).
Comment 3 Markus Knauer CLA 2010-05-25 04:46:14 EDT
One more question, because I didn't look at it in the past. I started a Helios RC1 package on Windows and used the standard 'Install new software' wizard to browse through the Helios /releases/helios repository. My expectation was that I am unable to see any of the Linux Tools IU's in the dialog because the dialog filters them out. But apparently my expectation was wrong. Or did I miss something?

Anyway, the new filter in the 
org.eclipse.epp.package.linuxtools.feature.feature.group looks good to me and I expect it to behave in the same way as the other Linux Tools IUs now:

      <filter>
        (&amp;(osgi.os=linux)(osgi.ws=gtk)(|(osgi.arch=x86)(osgi.arch=x86_64)))
      </filter>
Comment 4 Andrew Overholt CLA 2010-05-26 15:52:31 EDT
Pascal told me that the OS filters in our features aren't reflected in the generated metadata and thus non-Linux users *will* see our IUs in the UI.  I'd love it if this weren't the case.
Comment 5 David Williams CLA 2010-05-27 00:15:37 EDT
(In reply to comment #4)
> Pascal told me that the OS filters in our features aren't reflected in the
> generated metadata and thus non-Linux users *will* see our IUs in the UI.  I'd
> love it if this weren't the case.

Do you mean this as a problem with your build or p2 publisher? Or do you mean they exist in your specific repo, but are not copied over to common repo? 

If the later, please open a bug on b3.aggregator with details. 

Thanks,
Comment 6 Andrew Overholt CLA 2010-05-27 09:11:46 EDT
The way I understood it from Pascal was that the p2 UI will show all IUs on all OSes regardless of OS filter.  I was under the impression that it was a missing feature in the p2 UI and nothing else.
Comment 7 Pascal Rapicault CLA 2010-05-27 14:11:31 EDT
(In reply to comment #6)
> The way I understood it from Pascal was that the p2 UI will show all IUs on all
> OSes regardless of OS filter.  I was under the impression that it was a missing
> feature in the p2 UI and nothing else.
  Correct.
Comment 8 David Williams CLA 2010-05-27 15:35:45 EDT
>> ... it was a missing
>> feature in the p2 UI and nothing else.
>   Correct.

Ok, well be sure a bug is opened there, then! :)
Comment 9 Andrew Overholt CLA 2010-05-27 16:59:26 EDT
I see two potentially applicable p2 bugs:

272535: update-site doesn't show errors for features that are filtered based on platform
https://bugs.eclipse.org/bugs/show_bug.cgi?id=272535

225365: New update site manager does not filter features based on os correctly
https://bugs.eclipse.org/bugs/show_bug.cgi?id=225365
Comment 10 Andrew Overholt CLA 2010-06-11 10:33:28 EDT
I'm marking this as a duplicate of one of the applicable p2 bugs.

*** This bug has been marked as a duplicate of bug 225365 ***