Community
Participate
Working Groups
The contentType id for facelet and facelet composite respectively are: jsf.facelet and jsf.facelet.composite. All other contentType id's have the plugin that defines it as a prefix. We should consider doing the same. examples: org.eclipse.wst.xml.core.xmlsource org.eclipse.core.runtime.xml org.eclipse.emf.mapping.ecore2xml
Created attachment 170421 [details] Fixes the content type id to the recommend type.
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This is a stop-ship bug since it blocks 314903 which has also been raised for PMC approval. The later can result in poor perfromace. * Is there a work-around? If so, why do you believe the work-around is insufficient? No reasonable workaround * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Code review and manual testing. * Give a brief technical overview. Who has reviewed this fix? See comment 1 * What is the risk associated with this fix? low-medium
I could be wrong, but pretty sure these ID string are essentially API. Clients pretty much have to use them? In code or plugin.xml files? As you can see by your own use of it bug 314903. I'd fear others have "extended" one of these ... or using it a plugin.xml file? And they'd be broken? Have these been released in previous versions of WTP? Even if not, seems too late to make a breaking change now. I _think_ there might be ways to define a new one equivalent to an old one, so you can deprecate the old one but leave it in place for a a few releases ... but, even if so, I don't think we should be making that kind of change right now, since it is not really to solve a problem ... just be follow convention? Please don't hesitate to correct me, or tell me if I've misunderstood.
(In reply to comment #3) > I could be wrong, but pretty sure these ID string are essentially API. These ids have never been available in a release before. They were added in Helios as part of support for Facelets. I want to change these to the "non-discouraged" format now precisely because they will be very hard to change post-Helios. We can release a notice to the wtp-jsf-dev mailing list to warn any Helios adopters.
> These ids have never been available in a release before. They were added in > Helios as part of support for Facelets. I want to change these to the > "non-discouraged" format now precisely because they will be very hard to change > post-Helios. > Thanks for clarifying these were not in previous releases, but the deadline for API freeze is M6 ... so after that, it is just about as hard to change API, as after the release, if we take that commitment seriously (which I think we all do). We do sometimes have exceptions to the API freeze, but as far as I recall, those are to fix bad problems, which I don't see in this case.
PMC review feedback: API change not desirable at this stage. Withdrawing for this release. We will fix 314903 with the existing content type id.
This
